Skip to content

Update support data for touch-action property #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Update support data for touch-action property #3331

merged 2 commits into from
Apr 11, 2017

Conversation

huijing
Copy link

@huijing huijing commented Apr 7, 2017

Addresses #3325

@huijing
Copy link
Author

huijing commented Apr 7, 2017

There are 2 separate files for touch-action level 1 and touch-action level 2 but caniuse.com only shows the information for touch-action level 1. Is this because touch-action level 2 is still in WD status?

Copy link
Contributor

@lpd-au lpd-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test for IE seems to have borked, but the webkit code for touch-action seems to be behind a flag for touch events being enabled, which I assume isn't the case on desktop safari so good catch there.

@@ -37,7 +37,7 @@
"8":"n",
"9":"n",
"10":"a x #1",
"11":"a #1"
"11":"n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems patently incorrect to me.

@@ -274,7 +274,7 @@
},
"ie_mob":{
"10":"a x #1",
"11":"a #1"
"11":"n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for desktop IE

@@ -288,7 +288,7 @@
},
"notes":"Due to scoping issues of the W3C Pointer Events Working Group, `pinch-zoom` appears in the WHATWG Compatibility Standard instead of W3C Pointer Events Level 2.",
"notes_by_num":{
"1":"IE and Edge only support `pinch-zoom`.",
"1":"Edge only supports `pinch-zoom`.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@@ -47,7 +47,7 @@
"8":"n",
"9":"n",
"10":"y x #2",
"11":"y"
"11":"n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE10 was the first browser to support pointer events and touch-action, what gives you the impression it disappeared in IE11?

@@ -186,8 +186,8 @@
"9":"n",
"9.1":"a #3",
"10":"a #3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.1 and 10 should match 10.1 and TP

@@ -284,7 +284,7 @@
},
"ie_mob":{
"10":"y x #2",
"11":"y"
"11":"n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto previous comments re IE

@huijing
Copy link
Author

huijing commented Apr 8, 2017

@lpd-au thank you for reviewing. You are absolutely right, I forgot that IE11 does NOT support feature queries to begin with so that was a false negative. I've updated the pull request accordingly, as well as for the Safari data.

@lpd-au
Copy link
Contributor

lpd-au commented Apr 8, 2017

LGTM now, thanks :)

Fyi, I added the file for the spec level 2 values in a pull request that's still labelled needs data review, I'm not 100% sure who's trusted to conduct that though. The spec status shouldn't matter, afaik it's all about data integrity.

@Fyrd Fyrd merged commit e654898 into Fyrd:master Apr 11, 2017
@Fyrd
Copy link
Owner

Fyrd commented Apr 11, 2017

@huijing Thanks!

@lpd-au I will review the data, eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants