Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect missing key in a key-value pair #167

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented Jul 1, 2024

Description

The following invalid JSON document would be classified as valid JSON without this change:

{
    "key1":"val1",
    {
        "key2":"val2"
    }
}

The issue was reported here - #165.

Test Steps

Run updated unit tests.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#165

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The following invalid JSON document would be classified as valid JSON
without this change:
```
{
    "key1":"val1",
    {
        "key2":"val2"
    }
}
```

The issue was reported here - FreeRTOS#165.

Signed-off-by: Gaurav Aggarwal <[email protected]>
@aggarg aggarg requested a review from a team as a code owner July 1, 2024 16:38
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
@AniruddhaKanhere AniruddhaKanhere merged commit 10c26b8 into FreeRTOS:main Jul 1, 2024
11 checks passed
@aggarg aggarg deleted the issue_165 branch July 2, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants