Fix JSON validation for mismatched brackets #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
approved these changes
Jun 13, 2022
paulbartell
reviewed
Jun 13, 2022
| #define MISMATCHED_BRACKETS2_LENGTH ( sizeof( MISMATCHED_BRACKETS ) - 1 ) | ||
| #define MISMATCHED_BRACKETS2_LENGTH ( sizeof( MISMATCHED_BRACKETS2 ) - 1 ) | ||
|
|
||
| #define MISMATCHED_BRACKETS3 "{\"foo\":[\"bar\",\"xyz\"]]" |
There was a problem hiding this comment.
This is only used once.. Does it really need to be a #defined constant?
paulbartell
approved these changes
Jun 13, 2022
aggarg
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where an invalid JSON with mismatched outermost brackets may be marked as valid, e.g.
"{ \"Hello\": \"World\" ]". This is due to the validator not checking for matching brackets at the outermost depth.While fixing this, I also found a bug in the unit tests, where a case that was supposed to error was checking for success instead. If that test case had been correct, then this bug would've been caught.
It was a little frustrating running the unit tests on my computer, since they don't compile with gcc 10 or later. I had to pass in the cmake flag
-DCMAKE_C_FLAGS="-fcommon"in order to run them, which I couldn't find documented here. This hasn't been caught by GitHub Actions since Actions is usingubuntu-latest, which is still 20.04 and comes with an older version of gcc.