Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify license for Xtensa port #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

afoxley
Copy link

@afoxley afoxley commented Nov 23, 2024

Specify LICENSE for Xtensa port

Description

Each port subdirectory should specify the license of the source contained.

Test Steps

NA

Related Issue

NA

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@afoxley
Copy link
Author

afoxley commented Nov 23, 2024

@ianstcdns Please review

@ianstcdns
Copy link
Contributor

Given that the MIT license requires the copyright message to be placed in every file (“substantial portions”) regardless, it does seem a bit redundant to include a separate file with the same message. Is this something that Amazon is planning to standardize across the Partner-Supported and Community-Supported repos? Because only 2 of the 9-10 ports have license files, although these appear to be named LICENSE.md instead.

If this is part of a broader effort to standardize to this practice, I’m happy to go along with it, but if it’s only applied to the Xtensa port, I think our preference would be to leave this as-is.

@aggarg @RichardBarry

@afoxley
Copy link
Author

afoxley commented Dec 2, 2024

I filed an issue to get LICENSE files added to each port since the top level LICENSE file in this repo defers to them, but they currently don't exist. (https://github.com/FreeRTOS/FreeRTOS-Kernel-Partner-Supported-Ports/blob/main/README.md). So either that should be changed, or LICENSE files properly setup for each port.

@ianstcdns
Copy link
Contributor

Thanks; sounds good. I don't see an approve button, but I'm fine with this getting merged as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants