Address MISRA errors of various kinds #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanjos-dev
approved these changes
Sep 1, 2020
cobusve
approved these changes
Sep 1, 2020
AniruddhaKanhere
added a commit
that referenced
this pull request
Sep 22, 2020
* Add missing error state assignment. (#166) * MISRA compliance changes for FreeRTOS_TCP_IP.c (#160) * MISRA tcp-ip changes * Changes after Hein's comments on original PR * Update FreeRTOS_TCP_IP.c Co-authored-by: Yuhui Zheng <[email protected]> * MISRA compliance changes in FreeRTOS_Sockets{.c/.h} (#161) * MISRA changes Sockets * add other changes * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * correction * Add 'U' * Update FreeRTOS_Sockets.h * Update FreeRTOS_Sockets.h * Update FreeRTOS_Sockets.c * Update FreeRTOS_Sockets.h * Update after Gary's comments * Correction reverted * MISRA changes in FreeRTOS_TCP_WIN.c (#162) * UPD MISRA changes (#164) Co-authored-by: Yuhui Zheng <[email protected]> * MISRA compliance changes for FreeRTOS+TCP headers (#165) * misra changes * Update FreeRTOS_IP_Private.h * Update FreeRTOS_IP_Private.h * Misc changes (#183) * Remove dependency of CBMC on Patches (#181) * Changes to DHCP * CBMC DNS changes * Changes for TCP_IP * Changes to TCP_WIN * Define away static to nothing * Remove patches * Changes after Mark's comments v1 * Update MakefileCommon.json * Correction! * Remove CBMC patch which is not used anymore (#187) * Delete 0002-Change-FreeRTOS_IP_Private.h-union-to-struct.patch * Delete 0002-Change-FreeRTOS_IP_Private.h-union-to-struct.patch * Update previous AVR ATmega0 and AVR Dx projecs + addition of equivalent projects in MPLAB.X and IAR (#180) * Updated indentation in AVR_ATMega4809_Atmel_Studio and AVR_Dx_Atmel_Studio projects, plus small fixes in their readme files. * Added AVR_ATMega4809_IAR, AVR_ATMega4809_MPLAB.X, AVR_Dx_IAR and AVR_Dx_MPLAB.X demo projects. * Removed build artefacts and added .gitignore files in AVR_ATMega4809_MPLAB.X and AVR_Dx_MPLAB.X projects. Co-authored-by: Yuhui Zheng <[email protected]> * Removed a 16MByte flash image file that was checked in by mistake (several years ago). (#173) Remove the copies of lwIP that are no longer reference from demo projects. Co-authored-by: Carl Lundin <[email protected]> * Update wolfSSL to the latest version(v.4.4.0) (#186) * deleted old version wolfSSL before updating * updated wolfSSL to the latest version(v4.4.0) * updated wolfSSL to the latest version(v4.4.0) * added macros for timing resistance Co-authored-by: RichardBarry <[email protected]> Co-authored-by: Ming Yue <[email protected]> * Add MPU demo projects for NUCLEO-H743ZI2 board (#155) * Add MPU demo projects for NUCLEO-H743ZI2 board It contains projects for Keil uVision, STM32CubeIDE and IAR EW. This demo shows the use of newly added support for 16 MPU regions. Signed-off-by: Gaurav Aggarwal <[email protected]> * Delete not needed CMSIS files Signed-off-by: Gaurav Aggarwal <[email protected]> * Use chacheable RAM in IAR project for MPU_M7_NUCLEO_H743ZI2 project (#193) This change updates the IAR project for Nucleo H743ZI2 to use the cacheable DTC RAM and enables L1 cache. In order to ensure the correct functioning of cache, the project sets configTEX_S_C_B_SRAM in FreeRTOSConfig.h to not mark the RAM as shareable. Signed-off-by: Gaurav Aggarwal <[email protected]> * Use new QEMU test project to improve stream/message buffer tests (#168) * Add Eclipse/GCC project that targets the LM3S8962 QEMU model. * Get the Cortex-M QEMU project working. * Continue working on making stream buffer demo more robust and QEMU project. * Rename directory CORTEX_LM3S8986_QEMU to CORTEX_LM3S6965_QEMU. Work on making the Stream Buffer tests more robust. Check in before adding in the trace recorder. * Rename CORTEX_LM3S6969_QEMU to CORTEX_LM3S6969_GCC_QEMU. * Make the StreamBufferDemo.c common demo file (test file) more robust to other test tasks running at an equally high priority. * Work in progress checkin only - comments in main.c are incorrect. * Correct comments at the top of FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/main.c Make the message buffer tests more robust in the case the a message buffer becomes full when prvSenderTask() has a higher priority than the reader task. * Disable trace recorder in the LM3S6965 QEMU demo. * I'm dropping FreeRTOS-Kernel reference update, since this seems to break the CMBC CI. Co-authored-by: Yuhui Zheng <[email protected]> * Remove unused wolfSSL files. (#197) * Remove unused wolfSSL files. * Add back some removed ciphers. * Update VS project file. * Update #169 -- Percepio Tracealyzer Recorder v4.3.11 (#201) * * Pull Request for Percepio Tracealyzer Recorder v4.3.11 * Update Tracealyzer demo config file. Co-authored-by: Erik Tamlin <[email protected]> * RSK64M Demo - Fix build errors (#195) * Fix linking errors. Define task notification array size * CBMC: Add proof for vSocketBind (#202) * Add proof * Update * Update MakefileCommon.json * Undo changes * Undo changes in MakefileCommon.json * Update Makefile.json * Update Makefile.json * Update Makefile.json * Change v1 * Change v2 * CBMC proof for ulARPRemoveCacheEntryByMac (#198) * Add Proof * update * Delete ulARPRemoveCacheEntryByMAC_harness.c * Changes after Mark's comments * Update after @yanjos-dev's comment * Remove confusing variable name * Update ulARPRemoveCacheEntryByMac_harness.c * CBMC proof for vProcessGeneratedUDPPacket (#203) * Add Proof * Update * Update the proof * Update the proof * Clean-up * Clean-up v2 * Update freertos_api.c * update stub * Updating queue.c patches for CBMC proofs (#216) * Move forward Kernel submodule pointer (#218) * Move forward Kernel submodule pointer * Fixing patches for CBMC proofs * Update proofs to assume cTxLock != 127 * Update proofs to assume cRxLock != 127 * Fix warnings after moving callback prototypes (#208) * Recently the prototypes for the application hook functions were moved out of the kernel .c files and into the .h files. That changes results in compile time warnings for projects that provide hook functions with a slightly different prototype - in particular where signed char * is used in place of just char * as an older FreeRTOS coding convention required chars to be explicitly qualified as signed or unsigned. This checkin fixes the warnings by ensuring the signature of implemented hook functions matches the signature of the prototypes. * Fix Posix demo build and remove src directory (#213) * Fix: build errors, remove src directory and bring all files up * Fix: Remove not needed header * Doc: fix main comments * Doc: fix comment Co-authored-by: Alfred Gedeon <[email protected]> * Removed issue tempate for general inquiries, and hinted that users could use forum for such purpose. (#105) * List proofs and signoff (#194) * Utility macros to improve readability/static analysis. (#219) * Update FreeRTOS_IP_Private.h * Update FreeRTOS_Sockets.h * Update FreeRTOS_DNS.c * Correct version number * Update version number * Update version number * Add CBMC proof for prvProcessEthernetPacket (#199) * Add proof * Remove and Rename files * Modify the makefile * Update Makefile.json * Add _static to FreeRTOS_IP.c * Update prvProcessEthernetPacket_harness.c * Update the proof and add list to stubs * add assertions * Update the proof * cleanup * Update * Update after @yanjos-dev's comment * Remove unnecessary assumption * TCP: Address MISRA rule11.3 violations (#225) * Use unsigned types/constants where needed. (#226) Co-authored-by: Aniruddha Kanhere <[email protected]> * TCP: Address MISRA rule 11.3 violations (Part 2) (#227) * Address MISRA 21.15 violations in FreeRTOS_Sockets.c (#229) * Use unsigned types/constants where needed. * Address MISRA 21.15 violations in FreeRTOS_Sockets.c Co-authored-by: Aniruddha Kanhere <[email protected]> * Address a few MISRA 2.2 violations in FreeRTOS_IP.c (#230) * Make changes for MISRA rule 2.2 * Add comments to explain changes * Fix a typo * Actually fix a typo I missed a spot in the previous commit. * cbmc: Add patch to remove overflow assert (#232) * Fix the path and command in demo projects to make it compatiable to Linux and MacOS (#220) * Update the the path in .launch file to make it compatiable with MacOS/Linux. * Remove .exe from command and use slash in file path Co-authored-by: Cobus van Eeden <[email protected]> * Address MISRA errors of various kinds (#234) * MISRA 21.15 changes * MISRA 11.8 changes * Address various MISRA warnings v2 (#238) * Address some MISRA warnings * Change the return type * Update FreeRTOS_Sockets.c * Address various MISRA warnings v3 (#240) * Add a branch and make MISRA changes * initialize the value * Update after Gary's comments * Fix: Demo/RX100_RX113-RSK_Renesas_e2studio RTOS demo project build error (#224) Co-authored-by: Cobus van Eeden <[email protected]> * Create a new branch and address 10.8 warnings (#241) * TCP: Update History.txt file (#243) * Update the History.txt * Build: replace scons with makefile (#235) * Build: transform scons into Makefile * Build: add Makefile dependencies * Build: remove some tabs from Makefile * Build: Make builds out of source, move wait for event to kernel port * Test: update the full test to print status messages * Build: replace lpthread with pthread Co-authored-by: Alfred Gedeon <[email protected]> * Remove unused variable from TaskNotifyArray.c that was causing a compiler warning. (#233) * Move Kernel source pointer forward to latest * Create winbase.h (#248) * TCP: Update version number and History.txt (#247) * Update the version number * Update History.txt * Fix references to Linux instead of Windows * Removed reference to kbhit() which is no longer in the code * Fix: Make demo selector more user friendly (#249) Co-authored-by: Alfred Gedeon <[email protected]> * Fixed spelling in main.c * Fix the Posix port demo libpcap lib linking order issue in staic linking for WSL. (#251) * Various small formatting and wording changes in Linux demo * Added -D_WINDOWS_ which expands the timing margin on the Linux port full demo, and turned optimization off for better debugging * Implement dumping the Tracelyzer trace when pressing enter (#252) * Test: Press Enter to Trace dump on posix demo * Test: allow tracedump multiple times * Fix: main full demo * Sync main_full demo to match the Windows Simulator test list * Increase tracelyzer parameters to accomodate full demo scope * Reset error message on next check and update interval to 10s * Update kernel pointer to include Synopsis PR #110 * Update History.txt (#253) * Added some URL files and move submodule pointer along (#254) * Update main.c Remove unused variable from the MingW demo's main.c file. * Fix: Typo in posix networking demo (#259) Co-authored-by: Alfred Gedeon <[email protected]> * Adding some url files and moving the kernel pointer along (#260) * Added some URL files and move submodule pointer along * Add SiFive_HiFive1_RTOS_demo.url * Tracelyzer version updates (#261) * Update Tracelyzer version numbers * Update Version number to 10.4.0 (#237) * Update submodule pointer for Kernel to 10.4.0 version * Move released kernel pointer to the one where ASM files have the updated version number (#270) * Update kernel pointer * MISRA v5 (#272) * Address MISRA Rule violations (#274) * Use unsigned types/constants where needed. * Address MISRA 21.15 violations in FreeRTOS_Sockets.c * Address MISRA rule violations in code (primarily Rule 2.2) * Inline had been disabled for Coverity builds, preventing Coverity from correctly identifying dead code; this change removes the disabling of inline during Coverity builds. * Added an explanation for the inline suppression of Rule 11.4 in prvSocketValid(). Co-authored-by: Aniruddha Kanhere <[email protected]> * Sync kernel history.txt to this repo. (#275) * Build: Fix Demo/RX100-RSK_Renesas_e2studio RTOS demo project build error (#228) * Fix: Demo/RX100-RSK_Renesas_e2studio RTOS demo project build error * Update project files for e2 studio v4.0.2.008 (the same as Demo/RX100_RX113-RSK_Renesas_e2studio RTOS demo project) Co-authored-by: Ming Yue <[email protected]> * Fix: Demo/RX200_RX231-RSK_GCC_e2studio_IAR RTOS demo project IAR build error (#239) Co-authored-by: Ming Yue <[email protected]> * Sync back V10.4.1 (#282) * Move Kernel submodule pointer to 10.4.1 * Update version number to V10.4.1 (#281) * Update (.s, .S) kernel version numbers to 10.4.1 (#283) * version bump to 10.4.1 * update .s file version numbers * Update FreeRTOS/History.txt * version string update to 10.4.1 -- irrespective of file extension (#284) Update the remaining files that have reference to the version number in them. * Maintenance: Make Demo/RX600_RX64M_RSK_Renesas_e2studio RTOS demo project better (#231) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX200_RX231-RSK_GCC_e2studio_IAR folder (#255) Co-authored-by: Ming Yue <[email protected]> * Upgrade_GCC_project_for_e2v780_in_RX700_RX71M_RSK_GCC_e2studio_IAR (#257) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX100_RX113-RSK_GCC_e2studio_IAR folder (#258) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX600_RX64M_RSK_GCC_e2studio folder (#263) Co-authored-by: Ming Yue <[email protected]> * Fix: Demo/RX600_RX64M_RSK_GCC_e2studio RTOS demo project build error (#245) Co-authored-by: Ming Yue <[email protected]> * Fix warnings in CORTEX_M4F_STM32F407ZG-SK project (#287) The existing startup code was generating some warnings of the form "Label 'xxxxx' is defined pubweak in a section implicitly declared root". This change replaces the startup file with the one generated from latest STM32CubeMX to fix the above warnings. Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Carl Lundin <[email protected]> Co-authored-by: Yuhui Zheng <[email protected]> Co-authored-by: m17336 <[email protected]> Co-authored-by: RichardBarry <[email protected]> Co-authored-by: TakayukiMatsuo <[email protected]> Co-authored-by: Ming Yue <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: Erik Tamlin <[email protected]> Co-authored-by: David Chalco <[email protected]> Co-authored-by: Cobus van Eeden <[email protected]> Co-authored-by: alfred gedeon <[email protected]> Co-authored-by: Alfred Gedeon <[email protected]> Co-authored-by: Nathan Chong <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: Ravishankar Bhagavandas <[email protected]> Co-authored-by: NoMaY (a user of Japan.RenesasRulz.com) <[email protected]> Co-authored-by: yngki <[email protected]>
AniruddhaKanhere
added a commit
that referenced
this pull request
Sep 22, 2020
* Add missing error state assignment. (#166) * MISRA compliance changes for FreeRTOS_TCP_IP.c (#160) * MISRA tcp-ip changes * Changes after Hein's comments on original PR * Update FreeRTOS_TCP_IP.c Co-authored-by: Yuhui Zheng <[email protected]> * MISRA compliance changes in FreeRTOS_Sockets{.c/.h} (#161) * MISRA changes Sockets * add other changes * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * Update FreeRTOSIPConfig.h * correction * Add 'U' * Update FreeRTOS_Sockets.h * Update FreeRTOS_Sockets.h * Update FreeRTOS_Sockets.c * Update FreeRTOS_Sockets.h * Update after Gary's comments * Correction reverted * MISRA changes in FreeRTOS_TCP_WIN.c (#162) * UPD MISRA changes (#164) Co-authored-by: Yuhui Zheng <[email protected]> * MISRA compliance changes for FreeRTOS+TCP headers (#165) * misra changes * Update FreeRTOS_IP_Private.h * Update FreeRTOS_IP_Private.h * Misc changes (#183) * Remove dependency of CBMC on Patches (#181) * Changes to DHCP * CBMC DNS changes * Changes for TCP_IP * Changes to TCP_WIN * Define away static to nothing * Remove patches * Changes after Mark's comments v1 * Update MakefileCommon.json * Correction! * Remove CBMC patch which is not used anymore (#187) * Delete 0002-Change-FreeRTOS_IP_Private.h-union-to-struct.patch * Delete 0002-Change-FreeRTOS_IP_Private.h-union-to-struct.patch * Update previous AVR ATmega0 and AVR Dx projecs + addition of equivalent projects in MPLAB.X and IAR (#180) * Updated indentation in AVR_ATMega4809_Atmel_Studio and AVR_Dx_Atmel_Studio projects, plus small fixes in their readme files. * Added AVR_ATMega4809_IAR, AVR_ATMega4809_MPLAB.X, AVR_Dx_IAR and AVR_Dx_MPLAB.X demo projects. * Removed build artefacts and added .gitignore files in AVR_ATMega4809_MPLAB.X and AVR_Dx_MPLAB.X projects. Co-authored-by: Yuhui Zheng <[email protected]> * Removed a 16MByte flash image file that was checked in by mistake (several years ago). (#173) Remove the copies of lwIP that are no longer reference from demo projects. Co-authored-by: Carl Lundin <[email protected]> * Update wolfSSL to the latest version(v.4.4.0) (#186) * deleted old version wolfSSL before updating * updated wolfSSL to the latest version(v4.4.0) * updated wolfSSL to the latest version(v4.4.0) * added macros for timing resistance Co-authored-by: RichardBarry <[email protected]> Co-authored-by: Ming Yue <[email protected]> * Add MPU demo projects for NUCLEO-H743ZI2 board (#155) * Add MPU demo projects for NUCLEO-H743ZI2 board It contains projects for Keil uVision, STM32CubeIDE and IAR EW. This demo shows the use of newly added support for 16 MPU regions. Signed-off-by: Gaurav Aggarwal <[email protected]> * Delete not needed CMSIS files Signed-off-by: Gaurav Aggarwal <[email protected]> * Use chacheable RAM in IAR project for MPU_M7_NUCLEO_H743ZI2 project (#193) This change updates the IAR project for Nucleo H743ZI2 to use the cacheable DTC RAM and enables L1 cache. In order to ensure the correct functioning of cache, the project sets configTEX_S_C_B_SRAM in FreeRTOSConfig.h to not mark the RAM as shareable. Signed-off-by: Gaurav Aggarwal <[email protected]> * Use new QEMU test project to improve stream/message buffer tests (#168) * Add Eclipse/GCC project that targets the LM3S8962 QEMU model. * Get the Cortex-M QEMU project working. * Continue working on making stream buffer demo more robust and QEMU project. * Rename directory CORTEX_LM3S8986_QEMU to CORTEX_LM3S6965_QEMU. Work on making the Stream Buffer tests more robust. Check in before adding in the trace recorder. * Rename CORTEX_LM3S6969_QEMU to CORTEX_LM3S6969_GCC_QEMU. * Make the StreamBufferDemo.c common demo file (test file) more robust to other test tasks running at an equally high priority. * Work in progress checkin only - comments in main.c are incorrect. * Correct comments at the top of FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/main.c Make the message buffer tests more robust in the case the a message buffer becomes full when prvSenderTask() has a higher priority than the reader task. * Disable trace recorder in the LM3S6965 QEMU demo. * I'm dropping FreeRTOS-Kernel reference update, since this seems to break the CMBC CI. Co-authored-by: Yuhui Zheng <[email protected]> * Remove unused wolfSSL files. (#197) * Remove unused wolfSSL files. * Add back some removed ciphers. * Update VS project file. * Update #169 -- Percepio Tracealyzer Recorder v4.3.11 (#201) * * Pull Request for Percepio Tracealyzer Recorder v4.3.11 * Update Tracealyzer demo config file. Co-authored-by: Erik Tamlin <[email protected]> * RSK64M Demo - Fix build errors (#195) * Fix linking errors. Define task notification array size * CBMC: Add proof for vSocketBind (#202) * Add proof * Update * Update MakefileCommon.json * Undo changes * Undo changes in MakefileCommon.json * Update Makefile.json * Update Makefile.json * Update Makefile.json * Change v1 * Change v2 * CBMC proof for ulARPRemoveCacheEntryByMac (#198) * Add Proof * update * Delete ulARPRemoveCacheEntryByMAC_harness.c * Changes after Mark's comments * Update after @yanjos-dev's comment * Remove confusing variable name * Update ulARPRemoveCacheEntryByMac_harness.c * CBMC proof for vProcessGeneratedUDPPacket (#203) * Add Proof * Update * Update the proof * Update the proof * Clean-up * Clean-up v2 * Update freertos_api.c * update stub * Updating queue.c patches for CBMC proofs (#216) * Move forward Kernel submodule pointer (#218) * Move forward Kernel submodule pointer * Fixing patches for CBMC proofs * Update proofs to assume cTxLock != 127 * Update proofs to assume cRxLock != 127 * Fix warnings after moving callback prototypes (#208) * Recently the prototypes for the application hook functions were moved out of the kernel .c files and into the .h files. That changes results in compile time warnings for projects that provide hook functions with a slightly different prototype - in particular where signed char * is used in place of just char * as an older FreeRTOS coding convention required chars to be explicitly qualified as signed or unsigned. This checkin fixes the warnings by ensuring the signature of implemented hook functions matches the signature of the prototypes. * Fix Posix demo build and remove src directory (#213) * Fix: build errors, remove src directory and bring all files up * Fix: Remove not needed header * Doc: fix main comments * Doc: fix comment Co-authored-by: Alfred Gedeon <[email protected]> * Removed issue tempate for general inquiries, and hinted that users could use forum for such purpose. (#105) * List proofs and signoff (#194) * Utility macros to improve readability/static analysis. (#219) * Update FreeRTOS_IP_Private.h * Update FreeRTOS_Sockets.h * Update FreeRTOS_DNS.c * Correct version number * Update version number * Update version number * Add CBMC proof for prvProcessEthernetPacket (#199) * Add proof * Remove and Rename files * Modify the makefile * Update Makefile.json * Add _static to FreeRTOS_IP.c * Update prvProcessEthernetPacket_harness.c * Update the proof and add list to stubs * add assertions * Update the proof * cleanup * Update * Update after @yanjos-dev's comment * Remove unnecessary assumption * TCP: Address MISRA rule11.3 violations (#225) * Use unsigned types/constants where needed. (#226) Co-authored-by: Aniruddha Kanhere <[email protected]> * TCP: Address MISRA rule 11.3 violations (Part 2) (#227) * Address MISRA 21.15 violations in FreeRTOS_Sockets.c (#229) * Use unsigned types/constants where needed. * Address MISRA 21.15 violations in FreeRTOS_Sockets.c Co-authored-by: Aniruddha Kanhere <[email protected]> * Address a few MISRA 2.2 violations in FreeRTOS_IP.c (#230) * Make changes for MISRA rule 2.2 * Add comments to explain changes * Fix a typo * Actually fix a typo I missed a spot in the previous commit. * cbmc: Add patch to remove overflow assert (#232) * Fix the path and command in demo projects to make it compatiable to Linux and MacOS (#220) * Update the the path in .launch file to make it compatiable with MacOS/Linux. * Remove .exe from command and use slash in file path Co-authored-by: Cobus van Eeden <[email protected]> * Address MISRA errors of various kinds (#234) * MISRA 21.15 changes * MISRA 11.8 changes * Address various MISRA warnings v2 (#238) * Address some MISRA warnings * Change the return type * Update FreeRTOS_Sockets.c * Address various MISRA warnings v3 (#240) * Add a branch and make MISRA changes * initialize the value * Update after Gary's comments * Fix: Demo/RX100_RX113-RSK_Renesas_e2studio RTOS demo project build error (#224) Co-authored-by: Cobus van Eeden <[email protected]> * Create a new branch and address 10.8 warnings (#241) * TCP: Update History.txt file (#243) * Update the History.txt * Build: replace scons with makefile (#235) * Build: transform scons into Makefile * Build: add Makefile dependencies * Build: remove some tabs from Makefile * Build: Make builds out of source, move wait for event to kernel port * Test: update the full test to print status messages * Build: replace lpthread with pthread Co-authored-by: Alfred Gedeon <[email protected]> * Remove unused variable from TaskNotifyArray.c that was causing a compiler warning. (#233) * Move Kernel source pointer forward to latest * Create winbase.h (#248) * TCP: Update version number and History.txt (#247) * Update the version number * Update History.txt * Fix references to Linux instead of Windows * Removed reference to kbhit() which is no longer in the code * Fix: Make demo selector more user friendly (#249) Co-authored-by: Alfred Gedeon <[email protected]> * Fixed spelling in main.c * Fix the Posix port demo libpcap lib linking order issue in staic linking for WSL. (#251) * Various small formatting and wording changes in Linux demo * Added -D_WINDOWS_ which expands the timing margin on the Linux port full demo, and turned optimization off for better debugging * Implement dumping the Tracelyzer trace when pressing enter (#252) * Test: Press Enter to Trace dump on posix demo * Test: allow tracedump multiple times * Fix: main full demo * Sync main_full demo to match the Windows Simulator test list * Increase tracelyzer parameters to accomodate full demo scope * Reset error message on next check and update interval to 10s * Update kernel pointer to include Synopsis PR #110 * Update History.txt (#253) * Added some URL files and move submodule pointer along (#254) * Update main.c Remove unused variable from the MingW demo's main.c file. * Fix: Typo in posix networking demo (#259) Co-authored-by: Alfred Gedeon <[email protected]> * Adding some url files and moving the kernel pointer along (#260) * Added some URL files and move submodule pointer along * Add SiFive_HiFive1_RTOS_demo.url * Tracelyzer version updates (#261) * Update Tracelyzer version numbers * Update Version number to 10.4.0 (#237) * Update submodule pointer for Kernel to 10.4.0 version * Move released kernel pointer to the one where ASM files have the updated version number (#270) * Update kernel pointer * MISRA v5 (#272) * Address MISRA Rule violations (#274) * Use unsigned types/constants where needed. * Address MISRA 21.15 violations in FreeRTOS_Sockets.c * Address MISRA rule violations in code (primarily Rule 2.2) * Inline had been disabled for Coverity builds, preventing Coverity from correctly identifying dead code; this change removes the disabling of inline during Coverity builds. * Added an explanation for the inline suppression of Rule 11.4 in prvSocketValid(). Co-authored-by: Aniruddha Kanhere <[email protected]> * Sync kernel history.txt to this repo. (#275) * Build: Fix Demo/RX100-RSK_Renesas_e2studio RTOS demo project build error (#228) * Fix: Demo/RX100-RSK_Renesas_e2studio RTOS demo project build error * Update project files for e2 studio v4.0.2.008 (the same as Demo/RX100_RX113-RSK_Renesas_e2studio RTOS demo project) Co-authored-by: Ming Yue <[email protected]> * Fix: Demo/RX200_RX231-RSK_GCC_e2studio_IAR RTOS demo project IAR build error (#239) Co-authored-by: Ming Yue <[email protected]> * Sync back V10.4.1 (#282) * Move Kernel submodule pointer to 10.4.1 * Update version number to V10.4.1 (#281) * Update (.s, .S) kernel version numbers to 10.4.1 (#283) * version bump to 10.4.1 * update .s file version numbers * Update FreeRTOS/History.txt * version string update to 10.4.1 -- irrespective of file extension (#284) Update the remaining files that have reference to the version number in them. * Maintenance: Make Demo/RX600_RX64M_RSK_Renesas_e2studio RTOS demo project better (#231) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX200_RX231-RSK_GCC_e2studio_IAR folder (#255) Co-authored-by: Ming Yue <[email protected]> * Upgrade_GCC_project_for_e2v780_in_RX700_RX71M_RSK_GCC_e2studio_IAR (#257) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX100_RX113-RSK_GCC_e2studio_IAR folder (#258) Co-authored-by: Ming Yue <[email protected]> * Upgrade GCC project files for e2 studio v7.8.0 in Demo/RX600_RX64M_RSK_GCC_e2studio folder (#263) Co-authored-by: Ming Yue <[email protected]> * Fix: Demo/RX600_RX64M_RSK_GCC_e2studio RTOS demo project build error (#245) Co-authored-by: Ming Yue <[email protected]> * Fix warnings in CORTEX_M4F_STM32F407ZG-SK project (#287) The existing startup code was generating some warnings of the form "Label 'xxxxx' is defined pubweak in a section implicitly declared root". This change replaces the startup file with the one generated from latest STM32CubeMX to fix the above warnings. Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Carl Lundin <[email protected]> Co-authored-by: Yuhui Zheng <[email protected]> Co-authored-by: m17336 <[email protected]> Co-authored-by: RichardBarry <[email protected]> Co-authored-by: TakayukiMatsuo <[email protected]> Co-authored-by: Ming Yue <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: Erik Tamlin <[email protected]> Co-authored-by: David Chalco <[email protected]> Co-authored-by: Cobus van Eeden <[email protected]> Co-authored-by: alfred gedeon <[email protected]> Co-authored-by: Alfred Gedeon <[email protected]> Co-authored-by: Nathan Chong <[email protected]> Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: Ravishankar Bhagavandas <[email protected]> Co-authored-by: NoMaY (a user of Japan.RenesasRulz.com) <[email protected]> Co-authored-by: yngki <[email protected]>
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
* MISRA 21.15 changes * MISRA 11.8 changes
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
* 100% coverage * Fix broken build * Add default file back * Remove default file * Fix some checks * Update after review comments * Update v2 and added comments for tests. * Fixed checks * Update: added asserts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the total violations by eliminating a few violations of different kinds.
MISRA 11.18, 21.15 etc.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.