File export: generate a default filename if the selected object chang… #18907
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed since the last export
github-actions
bot
added
the
Mod: Core
hyarion
approved these changes
Jan 8, 2025
|
@maxwxyz can you approve the CI to run? |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first contribution to FreeCAD so bear with me. Often while modelling I'll make changes to parts and export with different file names. I noticed that if you export with a custom file name, subsequent export filenames are not what you would expect. See video example here:
freecad_export_orig.mp4
I made a very small adjustment to the export code so we now track if the selected object changes between exports and if so, we generate the default filename. I find this produces results which would be more expected by the user. See video after change here:
freecad_export_new.mp4
this fixes #18913