[Toponaming] Import code releted to _ElementMapVersion from LS3 #18791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mod: Core
luzpaz
requested changes
Dec 30, 2024
*Added test Signed-off-by: Vincenzo Calligaro <[email protected]>
*Imported original code
CalligaroV
force-pushed
the
toponaming-ElementMapVersion-code-from-LS3
branch
from
bec075a to
89ec079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports code related to
GeoFeature::_ElementMapVersionfrom LS3.The imported code helps improving the compatibility for models designed with pre v1.0 (pre Toponaming) versions of FreeCAD.
according to #17124 (comment) this fixes #17124 (the files Issue_examples.zip in the OP as well as Example3.zip in #17124 (comment))