Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAM Simulator] Add ifdef to fix OpenGL compatibility on linux. issue #18707 #18746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CAM Simulator] Add ifdef to fix OpenGL compatibility on linux. issue #18707 #18746

wants to merge 2 commits into from
+0 −1

Conversation

shaise
Copy link
Contributor

@shaise shaise commented Dec 27, 2024

No description provided.

@github-actions github-actions bot added the Mod: CAM Related to the CAM/Path Workbench label Dec 27, 2024
@maxwxyz maxwxyz linked an issue Dec 27, 2024 that may be closed by this pull request
Compilation issue on armel, armhf with debundled OpenGL headers, (glEnable(GL_MULTISAMPLE) ) #18707
Open
2 tasks
@maxwxyz maxwxyz added the Needs backport Needs backport to 1.0.1 label Dec 27, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 27, 2024

should be backported, right?

@shaise
Copy link
Contributor Author

shaise commented Dec 27, 2024

@maxwxyz , I really don't know. We did not have this issue when Ver1.0 was made. It is rather safe though.

@hyarion
Copy link
Contributor

hyarion commented Jan 1, 2025

Wouldn't it be easier to remove the line glEnable(GL_MULTISAMPLE)instead, given that it's never disabled and that the standard says:

The initial value for GL_DITHER and GL_MULTISAMPLE is GL_TRUE.

Or what do you think?

@shaise
Copy link
Contributor Author

shaise commented Jan 2, 2025 •
edited
Loading

@hyarion ,
You are absolutely correct. I have also debugged this flag just to make sure and indeed it is enables. This might also explain why this line did not seem to have any effect.
I have removed it completely.
Thanks.
@maxwxyz ,
I think its reasonable to backport it as well.

hyarion
hyarion approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@hyarion hyarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and backport 👍

It's always nice when bugs can be fixed by removing code 😅

@maxwxyz maxwxyz added the approved PR has approved reviews label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyarion hyarion hyarion approved these changes

Assignees

@sliptonic sliptonic

Labels
approved PR has approved reviews Mod: CAM Related to the CAM/Path Workbench Needs backport Needs backport to 1.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation issue on armel, armhf with debundled OpenGL headers, (glEnable(GL_MULTISAMPLE) )
4 participants
@shaise @maxwxyz @hyarion @sliptonic