Fix the crash in the interface for managing preference packs #18726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
|
Lint complaining about something in your commit:
|
|
If I declare a function as Fortunately, if it violates coding standards, pre-commit hooks will fix it before merge. |
|
We are trying to make our best to reduce lint warnings... @xtemp09 could you make the change? Apparently precommit didn't fix it. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18725. The cause of the crash is a direct invocation of
QDialog::showEvent(QShowEvent *event)withnullptr, leading to the segmentation fault. 1 Simple minuscule refactoring fixes it.Footnotes
https://github.com/qt/qtbase/blob/d89cef439f5c1a58aeff879a12d9a33292764b7f/src/widgets/dialogs/qdialog.cpp#L851-L860 ↩