[ArchStairs] Regression-fix : EnsureBase prevent creation #18651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stairs can do without Base. Base validity is tested in code. EnsureBase() is remarked out.
paullee0
changed the title
|
Likewise, ArchWall wiki - 'A wall can be built without any base object...', though ArchWall interactive mode always create base object. Not sure how an ArchWall could be created without a Base interactively (can remove the Base after creation of a Wall though), but ensureBase() is in contradiction to what wiki states. EDIT - #16409 |
|
Maybe it's better to have ensureBase let pass if there is no base? Or, give it a parameter that allows (or not) to have an empty base...
That's on my TODO list ;) |
|
Hmmm, would give it another thought |
|
In any case, let's merge this one already as it restores correct functionality. |
|
Maybe the checking should be done at creation commands, when user select base objects, e.g. :
Agreed? |
paullee0
added a commit
to paullee0/FreeCAD
that referenced
this pull request
Jan 4, 2025
Refer to discussion at - FreeCAD#18651 FreeCAD#16409 Wall should do without Base. Base validity tested in execute() prevented the desired and documented behaviour. EnsureBase() is remarked out in execute() and to be run in getExtrusionData(). With this fix, if there is no Base, or Base is not valid, Wall would be created as declared.
paullee0
added a commit
to paullee0/FreeCAD
that referenced
this pull request
Jan 5, 2025
Refer to discussion at - FreeCAD#18864 FreeCAD#18651 FreeCAD#16409 Like Wall, Stairs should do without Base. Base validity tested in execute() prevented the desired and documented behaviour. With this improvement, EnsureBase() is now only to be run when there is Base. If there is no Base, or Base is not valid, Stairs would be created as declared.
yorikvanhavre
pushed a commit
that referenced
this pull request
Jan 6, 2025
Refer to discussion at - #18864 #18651 #16409 Like Wall, Stairs should do without Base. Base validity tested in execute() prevented the desired and documented behaviour. With this improvement, EnsureBase() is now only to be run when there is Base. If there is no Base, or Base is not valid, Stairs would be created as declared.
yorikvanhavre
pushed a commit
that referenced
this pull request
Jan 6, 2025
Refer to discussion at - #18651 #16409 Wall should do without Base. Base validity tested in execute() prevented the desired and documented behaviour. EnsureBase() is remarked out in execute() and to be run in getExtrusionData(). With this fix, if there is no Base, or Base is not valid, Wall would be created as declared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stairs can do without Base. Base validity is tested in code.
EnsureBase() is remarked out.