App: Fix GeoFeature::getGlobalPlacement when rootObj is Link #18437
Conversation
This fixes a case when in case of rootObj being Link placement was not calculated correctly due to not changing of the document. While for original use it was fine as this was mostly used in case where there was defined non-link root for general case Links can be root objects of the document.
github-actions
bot
added
the
Mod: Core
|
Indeed in assembly this case never happened. As the root was always assembly. |
|
I can confirm that this partially fixes #18093, the Link2.FCStd in the zip file in that issue now works as expected with the align to selection tool and measure tool. However, the LinkTransform.FCStd does not work yet so let's keep the issue open when this is merged. |
|
@Rexbas I have found the issue: Placement for the Pad (not Body), is different from origin. That shouldn't be the case. I think that correct way here would be to close your issue end open one that is describing the issue with bad Placements on body features, what do you think? |
|
Hmm, interesting. Did you change an option to see the placement of the Pad in the property view? When I select the Pad in the tree view I don't see the placement in the property view... |
Yes, you need to check enable hidden (available in context menu) to see it. |
|
Thank you, I don't think the placement of the Pad causes the Links with Link Transform = true to behave bad. The 90 degree angle of the Pad does not explain the 30 degree angle error when aligning to the Link. Instead, I think when Link Transform = true, the Link "inherits" the global(?) placement of the referenced object and applies its own placement on top of it. Whereas a Link with Link Transform = false, only applies its own placement. |
|
Hey @kadet1090, you still working on this? Lets get this merged because it is an improvement. It doesn't matter that it only half fixes the issue, we will fix the other half another day 😃 |
|
Ah yes, I found even more problems with that implementation but in the end all were related to link transform so it seems safe to merge. Thanks for the ping! |
|
Is it now fully fixing #18093 after latest changes? |
|
No, only part of it. |
This fixes a case when in case of rootObj being Link placement was not calculated correctly due to not changing of the document. While for original use it was fine as this was mostly used in case where there was defined non-link root for general case Links can be root objects of the document.
partial fix for #18093
@PaddleStroke FYI
This could use backport.