IMO This is a bad move.

clang-tidy checks warnings exist precisely to warn of bad practises.

To say "creates more noise than it is worth" and turn them off is to say "no longer important - we don't care".

To go on and say "rely on code reviewers" is to justify something already decided unimportant becoming a nit-pick review opportunity. And nit-pick reviews are always bad.

This is not disabling the clang tidy, only one specific rule that is about short variable names. While usually this check is useful FreeCAD has quite a lot to do with math symbols - we often have variables like: x, y, z, t, u etc which really have no better name often. This check is very often a false positive and can be against common sense. In such case it is better to rely on reviewer to judge based on context where name like t is fine and where it is not.

x, y, z, t, u etc which really have no better name often

Ignores the fact that the clang-tidy warning exists to remind that single character variables are hard to see, easy to misread etc etc, regardless of where they are used.

Whilst it was the habit in the past to use single chars for some situations, that is IMO hardly an excuse to just ignore the problem when laziness suits. Need to set the goalposts just a little higher.

@adrianinsaval or @yorikvanhavre you want to weigh in and either merge or not? The consensus in today's PR review meeting was that removing this check is a good thing to do (nine attendees, none objecting).

Looks good to me, if we know specifically which letters are ok as names it looks like we could add them as exceptions if that's more desirable. I'll go ahead and merge this, it can be added back if people feel like we need it