Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling 3Dconnexion NavLib integration for MacOS #17000

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enabling 3Dconnexion NavLib integration for MacOS #17000

wants to merge 4 commits into from
+19 −13

Conversation

pskowronskiTDx
Copy link
Contributor

With the latest release of 3DxWareMac (version 10.8.5) we would like to introduce refined support for 3Dconnexion devices on MacOS. Also, the changes include two bug fixes:

  • Fixed detection of the active workbench at launch
  • Fixed a crash on closing the view tab while moving the 3D mouse's cap

@github-actions github-actions bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Packaging/building Related to building, compiling or packaging FreeCAD labels Oct 4, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Oct 4, 2024

@chennes can this go into 1.0?

@3x380V
Copy link
Contributor

3x380V commented Oct 4, 2024

So #16962 will be true for MacOS as well... @pskowronskiTDx, any plans to make it runtime decision?

@pskowronskiTDx
Copy link
Contributor Author

pskowronskiTDx commented Oct 4, 2024 •
edited
Loading

So #16962 will be true for MacOS as well... @pskowronskiTDx, any plans to make it runtime decision?

No. At least not at the moment.

@maxwxyz maxwxyz added this to the Post 1.0 milestone Oct 6, 2024
@maxwxyz maxwxyz mentioned this pull request Nov 4, 2024
Closed
2 tasks
@maxwxyz maxwxyz linked an issue Nov 13, 2024 that may be closed by this pull request
Navigation: Spacemouse not working on latest weekly builds #17665
Closed
2 tasks
@yorikvanhavre
Copy link
Member

We are thinking of making this a runtime decision, so we're leaving this waiting a bit more until we've figured out how to make it happen :)

@maxwxyz maxwxyz added the ✋ On hold This PR must not be merged before some condition is met label Nov 25, 2024
@chennes
Copy link
Member

chennes commented Nov 25, 2024

@yorikvanhavre is going to post on the forums to find someone with an older device who wants to help with this project.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 2, 2024

@yorikvanhavre could you share the forum link?

@yorikvanhavre
Copy link
Member

https://forum.freecad.org/viewtopic.php?t=92588

@maxwxyz maxwxyz mentioned this pull request Dec 2, 2024
Merged
@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 2, 2024

@yorikvanhavre this one: #18244 ?

@yorikvanhavre
Copy link
Member

@yorikvanhavre this one: #18244 ?

Yes! Amazing! Thanks @wwmayer 😎

@chennes
Copy link
Member

chennes commented Dec 6, 2024

I am going to re-test this now that we've merged that change.

@maxwxyz maxwxyz removed the ✋ On hold This PR must not be merged before some condition is met label Dec 6, 2024
@chennes chennes self-assigned this Dec 6, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 6, 2024

@chennes please note that #18244 is not merged yet

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 9, 2024

@pskowronskiTDx could you please resolve the conflict?

@maxwxyz maxwxyz closed this Dec 9, 2024
@maxwxyz maxwxyz reopened this Dec 9, 2024
@pskowronskiTDx
Copy link
Contributor Author

@maxwxyz Done, it should be working.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 10, 2024

@chennes please test

@maxwxyz maxwxyz requested a review from chennes December 13, 2024 09:57
@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 16, 2024

@chennes ping for test results

@chennes
Copy link
Member

chennes commented Dec 19, 2024 •
edited
Loading

When I test this PR with my SpaceMouse Enterprise, it doesn't work, and I get the following output on the console after I shut down.

CreateDirectory() bDirSuccess=1
2024-12-19 16:16:04.701 FreeCAD[28437:160696] ConnexionClientWriteCommands(via LIST) ...dict={
    Commands =     {
// chennes note: elided because it's long!
    };
}
2024-12-19 16:16:04.760 FreeCAD[28437:160384] +[IMKClient subclass]: chose IMKClient_Modern
2024-12-19 16:16:04.760 FreeCAD[28437:160384] +[IMKInputSession subclass]: chose IMKInputSession_Modern
Terminated connection with 3Dconnexion device.

Process finished with exit code 0

This was compiled with -DFREECAD_3DCONNEXION_SUPPORT="NavLib"

@adrianinsaval
Copy link
Member

Same thing for me

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 22, 2024

@pskowronskiTDx can you look into this?

@pskowronskiTDx
Copy link
Contributor Author

pskowronskiTDx commented Dec 23, 2024 via email

@maxwxyz
Copy link
Collaborator

maxwxyz commented Jan 4, 2025

thanks! (commenting so it is not on top of the queue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chennes chennes Awaiting requested review from chennes

@adrianinsaval adrianinsaval Awaiting requested review from adrianinsaval

Assignees

@chennes chennes

Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Packaging/building Related to building, compiling or packaging FreeCAD
Projects
None yet
Milestone
Post 1.0
Development

Successfully merging this pull request may close these issues.

Navigation: Spacemouse not working on latest weekly builds
6 participants
@pskowronskiTDx @maxwxyz @3x380V @yorikvanhavre @chennes @adrianinsaval