feat: add pnr validators (refs KDK-48741) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wallgren
requested review from
ext,
dvitamin,
NicklasWei,
MCFK,
OlofFredriksson,
TMFKse and
mitra-Re
as code owners
|
|
Validatorerna behöver dokumenteras här: Sedan vore det trevlig om validatorernas namn nämns i commit-meddelandet. Då syns dom tydligt i changelog sedan. Extra trevligt om det blir två commits. T.ex. |
dvitamin
reviewed
Nov 26, 2024
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.spec.ts
Outdated
Show resolved
Hide resolved
ext
previously approved these changes
Nov 27, 2024
packages/logic/src/services/ValidationService/Validators/NotSamePnrValue.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.spec.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.spec.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.spec.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/CompareAgePnrValue.ts
Outdated
Show resolved
Hide resolved
packages/logic/src/services/ValidationService/Validators/index.ts
Outdated
Show resolved
Hide resolved
daniel-wallgren
force-pushed
the
feat/add-pnr-validators
branch
from
91d3c25 to
ab1882e
Compare
daniel-wallgren
force-pushed
the
feat/add-pnr-validators
branch
from
ab1882e to
a941a8e
Compare
daniel-wallgren
force-pushed
the
feat/add-pnr-validators
branch
from
a941a8e to
84a5299
Compare
dvitamin
approved these changes
Nov 27, 2024
ext
approved these changes
Nov 28, 2024
MCFK
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validators for pnr:
v-validation.personnummerYounger- Check that one pnr field value isnt't younger than another.v-validation.personnummerOlder- Check that one pnr field value isnt't older than another.v-validation.personnummerNotSame- Check that one pnr field value isn't the same as another.