Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Jupyter notebook configuration file paths. #632

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

hacktobeer
Copy link
Contributor

Added more Jupyter configuration file paths using the below source.
https://docs.jupyter.org/en/latest/use/jupyter-directories.html#configuration-files

@hacktobeer
Copy link
Contributor Author

@joachimmetz could you do a review whenever time permits?

Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (be86a49) to head (2d1682b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   69.70%   69.55%   -0.15%     
==========================================
  Files           9        9              
  Lines         769      762       -7     
==========================================
- Hits          536      530       -6     
+ Misses        233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hacktobeer
Copy link
Contributor Author

Thanks for the cleanup. I see one codecov test failing, don't know if relevant....

@joachimmetz
Copy link
Member

Thanks for the cleanup. I see one codecov test failing, don't know if relevant....

That's fine, it just indicates that the patch reduced the overall test coverage stats

@joachimmetz joachimmetz merged commit 4eafd13 into ForensicArtifacts:main Aug 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants