Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added iOS and Android as supported Operating Systems #626

Merged
merged 2 commits into from
May 18, 2024

Conversation

rick-slin
Copy link
Contributor

I'd like to add iOS and Android as acceptable values for the supported_os field.

Thank you for your consideration.

@joachimmetz
Copy link
Member

We'll have to update the documentation as well https://github.com/ForensicArtifacts/artifacts/blob/main/docs/sources/Format-specification.md#supported-operating-system

I'll need to check with the GRR maintainers as well if this might cause issues.

@joachimmetz joachimmetz self-assigned this May 1, 2024
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz
Copy link
Member

Checked with GRR maintainers, no concerns from their end.

@joachimmetz joachimmetz merged commit 85ea189 into ForensicArtifacts:main May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants