Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for provides #275 #610

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

panhania
Copy link
Contributor

@panhania panhania commented Feb 8, 2024

GRR (which, as far as I know, was the only blocker for the deprecation) does not rely on this feature anymore.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6304c2b) 69.85% compared to head (1d6328e) 69.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   69.85%   69.70%   -0.16%     
==========================================
  Files           9        9              
  Lines         773      769       -4     
==========================================
- Hits          540      536       -4     
  Misses        233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joachimmetz
Copy link
Member

Thanks I'll take a look later this week

@joachimmetz joachimmetz self-assigned this Feb 9, 2024
@joachimmetz joachimmetz changed the title Removed support for provides (#275) Removed support for provides #275 Feb 10, 2024
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz joachimmetz merged commit 3e69de8 into ForensicArtifacts:main Feb 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants