Temporarily removing Windows from UsersDirectory #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e tests of GRR started to break due to the UsersDirectory supporting Windows. The issue is that this definition uses "provides: [users.username]" and the Knowledge Base used by GRR relies on it, so suddenly it has an unexpected list of users. As a temporary solution until we figure out a better one, I'd ask that we remove the Windows support so the GRR builds can pass again.
|
@joachimmetz - PTAL :) |
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 7 7
Lines 449 449
=======================================
Hits 396 396
Misses 53 53 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests of GRR started to break due to the UsersDirectory supporting Windows. The issue is that this definition uses "provides: [users.username]" and the Knowledge Base used by GRR relies on it, so suddenly it has an unexpected list of users.
As a temporary solution until we figure out a better one, I'd ask that we remove the Windows support so the GRR builds can pass again.