Skip to content

Conversation

@DeKe42
Copy link
Contributor

@DeKe42 DeKe42 commented Aug 27, 2019

This pull requests makes some smaller changes:

  • Fixes some spelling and documentation
  • Uses %%users.userprofile%% instead of homedir for Windows artifacts consistently
  • Improve some artifacts by using localappdata instead of hard-coding the path
  • Add missing user key for WindowsUninstallKeys and also match subkeys for more information about uninstall entries
  • Add another timezone key name to WindowsTimezone
  • Add another location to InternetExplorerHistory for older IE versions

@joachimmetz joachimmetz self-requested a review August 28, 2019 06:40
@joachimmetz
Copy link
Member

thx, for the PR I have a look when time permits. The CI test however are failing with an assertion issue in java.yaml

======================================================================
FAIL: testArtifactDefinitionsValidator (validator_test.ArtifactDefinitionsValidatorTest)
Runs the validator over all the YAML artifact definitions files.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/artifacts/tests/validator_test.py", line 27, in testArtifactDefinitionsValidator
    result, msg='in definitions file: {0}'.format(definitions_file))
AssertionError: in definitions file: data/java.yaml
----------------------------------------------------------------------

@joachimmetz joachimmetz self-assigned this Aug 28, 2019
@DeKe42
Copy link
Contributor Author

DeKe42 commented Aug 28, 2019

Interesting, the test fails because it does not recognize %%users.localappdata_low%%, but that is actually defined in the provides-section of WindowsUserShellFolders.

@joachimmetz
Copy link
Member

Yeah, that might be strict check to catch GRR legacy stuff (also see #275). I'll have a look when time permits.

@joachimmetz
Copy link
Member

The reason for the error is that %localappdata_low% does not exist as environment variable

paths:
- '%%users.appdata%%\Sun\Java\Deployment\cache\**'
- '%%users.userprofile%%\AppData\LocalLow\Sun\Java\Deployment\cache\**'
- '%%users.localappdata_low%%\Sun\Java\Deployment\cache\**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep this one as-is since %localappdata_low% does not exist as a default environment variable

@joachimmetz
Copy link
Member

@DeKe42 thx for the changes. Overall changes LGTM. I've reverted the changes to Java.yaml and created a new PR #372 to trigger the tests on current HEAD. Closing this PR in favor of the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants