-
Notifications
You must be signed in to change notification settings - Fork 219
Small improvements #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements #357
Conversation
|
thx, for the PR I have a look when time permits. The CI test however are failing with an assertion issue in java.yaml |
|
Interesting, the test fails because it does not recognize |
|
Yeah, that might be strict check to catch GRR legacy stuff (also see #275). I'll have a look when time permits. |
|
The reason for the error is that |
| paths: | ||
| - '%%users.appdata%%\Sun\Java\Deployment\cache\**' | ||
| - '%%users.userprofile%%\AppData\LocalLow\Sun\Java\Deployment\cache\**' | ||
| - '%%users.localappdata_low%%\Sun\Java\Deployment\cache\**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep this one as-is since %localappdata_low% does not exist as a default environment variable
This pull requests makes some smaller changes:
%%users.userprofile%%instead ofhomedirfor Windows artifacts consistentlylocalappdatainstead of hard-coding the pathWindowsUninstallKeysand also match subkeys for more information about uninstall entriesWindowsTimezoneInternetExplorerHistoryfor older IE versions