Feature/sonix ai audio loader #1169
Open
+116
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but did not test it out cause the apikey needs enterprise subscription
HenryHengZJ
reviewed
Nov 10, 2023
HenryHengZJ
reviewed
Nov 10, 2023
HenryHengZJ
reviewed
Nov 10, 2023
HenryHengZJ
reviewed
Nov 10, 2023
| if(!sonixAuthKey) return | ||
| const cache = nodeData.inputs?.cache as BaseCache | ||
|
|
||
| // const obj: Partial<SonixAiInput> = { |
Contributor
There was a problem hiding this comment.
redundant commented codes?
Author
There was a problem hiding this comment.
removed all redundant code and comments in the next commit.
Thank you for the review. This is my first open source contribution so please suggest me anything that i have to change to improve my open source journey.
… // removed audio filename as input thing and took from uploaded filename // removed unwanted code and comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SonixAi node and credential in Codebase and are reflecting in Ui. But did not test it cause the subscription that is needed for api is enterprise subscription.