Add named terrain layers #3021
Merged
Add named terrain layers #3021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolfInABowl
reviewed
Oct 25, 2024
Makes the name shorter, fits into comboboxes more easily
WolfInABowl
reviewed
Oct 25, 2024
mafiesto4
requested changes
Nov 5, 2024
| /// The layers names. | ||
| /// </summary> | ||
| [EditorOrder(10), EditorDisplay("Terrain Layers", EditorDisplayAttribute.InlineStyle), Collection(CanResize = false, Display = CollectionAttribute.DisplayType.Inline)] | ||
| public string[] TerrainLayers = Enumerable.Repeat(string.Empty, 8).ToArray(); |
Member
There was a problem hiding this comment.
Make it inlined to reduce engine startup time (JIT won't need to use Linq).
Contributor
Author
There was a problem hiding this comment.
Done in 75d4a11.
I also had to remove the ToArray(), which leads to the Terrain layer names being populated with Layer {index} by default:
Before it looked like this:
The new behavior might actually make more sense because there will always be 8 terrain layers, so they all need names (unlike f.e. "normal" layers).
However if that's a problem I can try to find a solution.
mafiesto4
reviewed
Nov 5, 2024
mafiesto4
reviewed
Nov 18, 2024
mafiesto4
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to assign names to terrain layers via a new section Terrain Layers in Layers And Tags Settings.
Uses a custom editor (
TerrainLayerEditor) to display the names.If there is no name assigned in the settings, the layer is displayed as "Layer" + layer index (f.e. "Layer 1").
It'd be cool if someone could test this a bit. I did some testing, but it was so much more easy to implement than I expected, I'm worried I missed something.
I'd like to receive feedback on
LayersAndTagsSettings.GetCurrentTerrainLayers(), especially about the part where I load the settings.