Skip to content

Make it possible to pan visject editor when rmb down on node #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flaxtechnology merged 2 commits into from
Oct 2, 2025
Merged

Make it possible to pan visject editor when rmb down on node #2931

flaxtechnology merged 2 commits into from
Oct 2, 2025

Conversation

@xxSeys1
Copy link
Contributor

@xxSeys1 xxSeys1 commented Sep 14, 2024 •
edited
Loading

Currently you have to start the right click in an empty space in the node editor.

This pr makes it possible to also start right click on a node by checking if the mouse moved.

Closes #2479.

@xxSeys1 xxSeys1 changed the title Make it possible to pan editor when rmb down on node Make it possible to pan visject editor when rmb down on node Sep 14, 2024
@xxSeys1
Copy link
Contributor Author

xxSeys1 commented Sep 15, 2024

Dunno why the Linux check failed, seems to have something to do with nuget

@mafiesto4 mafiesto4 added enhancement New feature or request visject Visject surface used by materials, particles, visual scripts and more labels Sep 15, 2024
@mafiesto4
Copy link
Member

mafiesto4 commented Sep 15, 2024

You could use Float2 location instead Input.Mouse.Position and apply some safe margin (like 4 pixels) when checking if mouse moved.

@xxSeys1
add safe margin
e665cc7 
4 pixels seemed a bit much, smaller adjustments could lead to the menu still showing
@xxSeys1
Copy link
Contributor Author

xxSeys1 commented Sep 16, 2024

You could use Float2 location instead Input.Mouse.Position and apply some safe margin (like 4 pixels) when checking if mouse moved.

I tried using Float2 location but it wasn't working anymore, so I'm back to Input.Mouse.Position now.

@mafiesto4 mafiesto4 added this to the 1.10 milestone Sep 18, 2024
@mafiesto4 mafiesto4 removed this from the 1.10 milestone Mar 16, 2025
@xxSeys1 xxSeys1 mentioned this pull request Jun 11, 2025
Merged
@xxSeys1
Copy link
Contributor Author

xxSeys1 commented Sep 24, 2025 •
edited
Loading

@mafiesto4 Can this be merged for 1.11?

There are a lot new Visject features and fixes, so I think a lot of people who will give Flax a try will try out Visject based tools.

Not being able to pan the editor when starting the mouse drag on a node is a major pain point and feels unpolished in my opinion.
The changes made are also very small. It was also on the 1.10 milestone before.

I have been using my custom branch, with this pr merged in, for about half a year now and I never noticed any issues with it.

@mafiesto4 mafiesto4 added this to the 1.11 milestone Sep 24, 2025
@flaxtechnology flaxtechnology merged commit 7c87ade into FlaxEngine:master Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request visject Visject surface used by materials, particles, visual scripts and more

Projects

None yet

Milestone

1.11

Development

Successfully merging this pull request may close these issues.

[Proposal] Make it possible to pan view in node editor when starting rightlick on node

3 participants

@xxSeys1 @mafiesto4 @flaxtechnology