Skip to content

Improve output log scroll #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xxSeys1
Copy link
Contributor

@xxSeys1 xxSeys1 commented Sep 13, 2024

This pr aims to make improvements to output log scrolling

TODO

  • Implement scroll to bottom on new line
  • Add scroll to bottom on enter play
  • Fix scroll after resizing output log

@xxSeys1 xxSeys1 changed the title improve output log scroll Improve output log scroll Sep 13, 2024
@xxSeys1
Copy link
Contributor Author

xxSeys1 commented Sep 13, 2024

One problem this pr might be causing is that the output log will now scroll to the bottom for every new entry.
That editor setting was enabled before by default but not implemented. I'd imagine that most people prefer the old behavior without auto scroll because they've gotten used to it by now.

Maybe mention this fact in the release notes to avoid confusion?

Also I was considering to disable this option by default, but I kept it enabled for now cause that's how it has been so far.

@xxSeys1 xxSeys1 marked this pull request as ready for review September 13, 2024 21:12
@mafiesto4 mafiesto4 added enhancement New feature or request editor labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants