Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Fix unbound methods on upload task from $firebaseStorage (#925) #930

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Fix unbound methods on upload task from $firebaseStorage (#925) #930

merged 1 commit into from
Aug 16, 2017

Conversation

deoxen0n2
Copy link
Contributor

Description

Sorry took me so long. This should fix #925. This is the first code contribution so if I did anything wrong please tell me :D

Code sample

Now this code should run correctly:

const imageStorageRef = firebase.storage().ref('images')
const imageStorage = $firebaseStorage(imageStorageRef)
const uploadTask = imageStorage.$putString(image, 'base64')

uploadTask.then((snap) => {
  console.log('downloadURL:', snap.downloadURL)
})

// Also .catch(), .$pause(), .$resume(), and .$cancel() should work as expected.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0f128cf on deoxen0n2:master into ** on firebase:master**.

@davideast
Copy link
Contributor

Hey @deoxen0n2! Sorry for the extremely, extremely, delayed response. This is great, I'm merging it on in. Thank you so much for your contribution.

@davideast davideast merged commit b6dca6e into FirebaseExtended:master Aug 16, 2017
@Xsmael
Copy link

Xsmael commented Apr 12, 2018

Has this been fixed on the version available on the CDN link ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot call .then on UploadTask
4 participants
@deoxen0n2 @coveralls @davideast @Xsmael