Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Declare strict types in test/ #780

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Enhancement: Declare strict types in test/ #780

merged 3 commits into from
Sep 22, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 22, 2023 •
edited
Loading

What is the reason for this PR?

  • requires code in test/ to declare strict types
  • runs make cs
  • casts values to expected types

Related to #742.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@localheinz localheinz added the enhancement New feature or request label Sep 22, 2023
@localheinz localheinz self-assigned this Sep 22, 2023
@localheinz localheinz marked this pull request as draft September 22, 2023 07:39
@localheinz localheinz marked this pull request as ready for review September 22, 2023 07:49
@localheinz localheinz removed their assignment Sep 22, 2023
@localheinz localheinz force-pushed the feature/declare-strict-types branch from 9296c8d to 1a50cdb Compare September 22, 2023 07:56
@localheinz localheinz marked this pull request as draft September 22, 2023 07:56
@localheinz localheinz force-pushed the feature/declare-strict-types branch from cbc0b7f to e6e772e Compare September 22, 2023 08:00
@localheinz localheinz marked this pull request as ready for review September 22, 2023 08:00
@localheinz localheinz mentioned this pull request Sep 22, 2023
Merged
5 tasks
@bram-pkg bram-pkg merged commit a734bf0 into FakerPHP:2.0 Sep 22, 2023
12 checks passed
@localheinz localheinz deleted the feature/declare-strict-types branch September 22, 2023 09:01
@localheinz
Copy link
Member Author

Thank you, @bram-pkg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

@pimjansen pimjansen Awaiting requested review from pimjansen

Assignees

@bram-pkg bram-pkg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @bram-pkg