Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some SA issues and allow tools to be run locally easily #47

Merged
merged 2 commits into from
Nov 14, 2020
Merged

Fix some SA issues and allow tools to be run locally easily #47

merged 2 commits into from
Nov 14, 2020

Conversation

GrahamCampbell
Copy link
Member

See title. ;)

@GrahamCampbell GrahamCampbell mentioned this pull request Nov 14, 2020
Merged
@GrahamCampbell
Copy link
Member Author

BC Check warning is a false positive. The original phpdoc was incorrect.

@Nyholm
Copy link
Member

Nyholm commented Nov 14, 2020

Can you also update .gitattributes for the vendor-bin?

@GrahamCampbell
Copy link
Member Author

Done. :)

Nyholm
Nyholm approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@GrahamCampbell GrahamCampbell merged commit 647ef44 into main Nov 14, 2020
@GrahamCampbell GrahamCampbell deleted the static-analysis branch November 14, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @Nyholm