-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Add shouldCallDirectly for closeModal logic #53873
[CP Staging] Add shouldCallDirectly for closeModal logic #53873
Conversation
@Beamanator @youssef-lr I’ve finished creating the pull request to fix the issue #53848. Can you check it? |
🚧 @youssef-lr has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
…ace-receipt [CP Staging] Add shouldCallDirectly for closeModal logic (cherry picked from commit b29b3e4) (CP triggered by Beamanator)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.73-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Details
Fixed Issues
$ #53848
PROPOSAL: N/A
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-10.at.23.46.22.mov
Android: mWeb Chrome
Screen.Recording.2024-12-10.at.23.45.41.mov
iOS: Native
Screen.Recording.2024-12-10.at.23.42.17.mov
iOS: mWeb Safari
Screen.Recording.2024-12-10.at.23.43.49.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-10.at.23.49.01.mp4
MacOS: Desktop
Screen.Recording.2024-12-10.at.23.48.25.mp4