-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Web - RHP - Going back closes the RHP Instead of navigating to the confirm page #53629
Fix - Web - RHP - Going back closes the RHP Instead of navigating to the confirm page #53629
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Ahh, oke we can't open deeplink with backto param |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeuntitled1.webmAndroid: mWeb ChromeScreen.Recording.2024-12-10.at.17.40.55.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-10.at.17.46.02.mp4iOS: mWeb SafariScreen.Recording.2024-12-10.at.17.27.44.movMacOS: Chrome / SafariScreen.Recording.2024-12-10.at.17.26.14.movMacOS: DesktopScreen.Recording.2024-12-10.at.17.42.02.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.74-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀
|
Details
Fixed Issues
$ #53253
PROPOSAL: #53253 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
a.back.mp4
Android: mWeb Chrome
aw.mp4
iOS: Native
i.mp4
iOS: mWeb Safari
iw.mp4
MacOS: Chrome / Safari
2024-12-09.14-56-19.mp4
MacOS: Desktop
d.mp4