-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cacheloads flag related fixes so insertsort_alt works with cacheloads=true #18
Conversation
… tests all use cachereads=true
Can you rebase off the current plugin branch so I can see what the differences are (this seems to include prior commits which makes reading it harder$ |
The actual diff is pretty small. You should be able to just quickly scan through all changes to sanity check the diff. The extraneous changes are from pulling plugin so to allow for an automatic merge. Also, in case there's confusion: you originally created this "morefix" branch. For some reason there are 2 branches (morefix and simplefix) that both have the commit which added the cachereads flag. |
enzyme/Enzyme/EnzymeLogic.cpp
Outdated
inst = cast<Instruction>(gutils->addMalloc(BuilderZ, inst)); | ||
llvm::errs() << "before cast inst :" << *inst << "\n"; | ||
llvm::errs() << "Cast successful " << "\n"; | ||
//llvm::errs() << "Forcibly loading cached reads after addmalloc " << *op << "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these prints
Tentatively approved but please remove prints. Also please do rebase and merge rather than squash and merge so the previous fixes in that branch are separate. Otherwise LGTM |
Closing this, see #19 |
No description provided.