Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New player event: PLAYER_EVENT_ON_PET_ADDED_TO_WORLD #387

Closed
wants to merge 1 commit into from
Closed

New player event: PLAYER_EVENT_ON_PET_ADDED_TO_WORLD #387

wants to merge 1 commit into from

Conversation

UltraNix
Copy link
Contributor

No description provided.

@FrancescoBorzi
Copy link
Contributor

@Rochet2 can you please merge this PR?

@55Honey
Copy link
Contributor

55Honey commented Sep 28, 2021

Tested with 55Honey/Acore_ZoneDebuff#2
Works as intended including pets and minions.

@55Honey
Copy link
Contributor

55Honey commented Sep 29, 2021

Matching PR to fix build exists on AC.
azerothcore/azerothcore-wotlk#8084

@yuanf225
Copy link

yuanf225 commented Oct 1, 2021

Currently the AC+eluna module cannot be compiled

@55Honey
Copy link
Contributor

55Honey commented Oct 1, 2021

Currently the AC+eluna module cannot be compiled

@yuanf225 You should open a new issue about it on and AC repo because it is not related to this PR. The matching PR on AC is not merged yet.

@Helias
Copy link

Helias commented Oct 3, 2021

@Rochet2 what about merging it?

1 similar comment
@yuanf225
Copy link

yuanf225 commented Oct 4, 2021

@Rochet2 what about merging it?

@55Honey
Copy link
Contributor

55Honey commented Oct 15, 2021

Included in #393

@Rochet2
Copy link
Member

Rochet2 commented Nov 25, 2021

New hooks are not likely to be added at this time as they require core changes.
New hooks may be added if they document the core they work on

ps. I think the TC build failure has been fixed. Should probably rerun checks.

@UltraNix UltraNix closed this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants