Support reading FAT long file names (VFAT) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
any comment on this? |
|
It would be very helpful if DiscUtils supported FAT32 long names for reading and writing because the file system is so widely used. |
|
This PR has a bug where the long name isn't used if the name has a |
|
How do I access the code from this branch? |
Contributor
@Thealexbarney or @drebrez Anyone feels like fixing that bug (and perhaps adding a unit test)? |
Author
|
Unfortunately I'm not using this library anymore and I don't really have time to look into it. @Thealexbarney feel free to take over the PR and fix the bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #71, here is the implementation to support reading the long file names in the FAT partition.
I manually tested all the possible use cases that came to my mind, and everything works fine.
About handling the writing of LFN, the current FAT project already have the _fatVariant which handles the differences between FAT12/FAT16/FAT32.
By default
FatFileSystem.FormatPartitioncreates aFAT16variant (see here). And he only variant not supporting the LFN it's the FAT8.So IMHO it's not really necessary to have a separate project to handle the writing of the VFAT, but should be the currect project to be extended further.
Let me know what you think about it.