Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted group orientation change when using mixed orientation #431

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

KuroiRoy
Copy link

@KuroiRoy KuroiRoy commented Mar 17, 2023

Dragging a floating document into the top or bottom of another document that is in a horizontal layout causes an unexpected change in the layout group. This only happens when using AllowMixedOrientation as the placement is not allowed otherwise.

As you can see in this example, a tab was dragged from the right side onto the bottom of another document:
Schermafbeelding 2023-03-17 160830

Which causes the whole layout to change:
Schermafbeelding 2023-03-17 160843

With the changes from this pull request the document is placed in the expected position:
Schermafbeelding 2023-03-17 161036

@james089
Copy link

This is indeed annoying, hope this fix can be merged soon...

@Dirkster99 Dirkster99 merged commit e5f732a into Dirkster99:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants