Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 163: IsSelected vs IsActive behavior changed from 3.x to 4.1/4.2 #243

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Issue 163: IsSelected vs IsActive behavior changed from 3.x to 4.1/4.2 #243

merged 1 commit into from
Feb 24, 2021

Conversation

triman
Copy link
Contributor

@triman triman commented Feb 23, 2021 •
edited
Loading

To reproduce the issue:

  1. Open the MVVM example, select the "Aero" theme (makes the steps in the ui easier)
  2. Open 2 documents. the 2 documents are displayed in 2 distinct tabs (correct)
  3. Change documents by clicking on the tab header, outside the text label (with aero theme, click on the spline on the left part of the tab). The displayed tab changes (correct), the lower toolwindow (display of the document properties) does not change (incorrect).

The lower toolwindow is bound on the ActiveDocument (defined by the "IsActive" flag), the displayed tab is based on the "IsSelected" flag.

Fix: re-integrated code from older version (removed in rev 4927453)

Resolves #163

@triman
Issue 163: IsSelected vs IsActive behavior changed from 3.x to 4.1/4.2
3fadf27 
Fix: re-integrated code from older version (removed in rev 4927453)
@Dirkster99 Dirkster99 merged commit b76221b into Dirkster99:master Feb 24, 2021
@Dirkster99 Dirkster99 mentioned this pull request Feb 24, 2021
Merged
@Dirkster99
Copy link
Owner

I am sorry but I had to decline/revert your Pull Request since the outlined test behavior did not change after merging the Pull Request (the name of the document was still not changed when clicking the non-title part of the document tab).

Please review your changes and see if you can provide a fix that works. It would also be great if you could supply a solution with the same coding style as the style in the repository because it is otherwise really difficult to see what changed and what not, thanks a lot though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsSelected vs IsActive behavior changed from 3.x to 4.1/4.2?
2 participants
@triman @Dirkster99