Skip to content

Change f_de parametrization to avoid division by log(1) #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2022
Merged

Change f_de parametrization to avoid division by log(1) #83

merged 3 commits into from
Jan 20, 2022

Conversation

eelregit
Copy link
Contributor

Parametrization is changed from $a^f_old(a)$ to $e^f_new(a)$.

@eelregit eelregit force-pushed the eelregit_f_de_patch branch from 4839d45 to 5e0e437 Compare January 20, 2022 01:11
EiffL
EiffL approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Yin! I've also added a test to make sure everything still behaves as expected

@EiffL EiffL merged commit 52ca009 into DifferentiableUniverseInitiative:master Jan 20, 2022
@eelregit eelregit deleted the eelregit_f_de_patch branch January 20, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffL EiffL EiffL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eelregit @EiffL