Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate sqrtk accessor #63

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Remove duplicate sqrtk accessor #63

merged 2 commits into from
Oct 17, 2020

Conversation

aboucaud
Copy link
Contributor

This PR aims at removing that duplicate entry.
I could not find any self._sqrtk attribute defined in the code.

An other possibility is that the above method is renamed def sqrtk(self) => def _sqrtk(self)
But I don't see the purpose.

@EiffL
Copy link
Member

EiffL commented Oct 17, 2020

Fair enough ^^

@EiffL EiffL self-requested a review October 17, 2020 17:48
EiffL
EiffL approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffL EiffL merged commit e71b827 into DifferentiableUniverseInitiative:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffL EiffL EiffL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboucaud @EiffL