This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Web UI: Replace plotly.js with echarts #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defkev
force-pushed
the
pr-webui-echarts
branch
from
a5958cb to
e0f29d4
Compare
|
Look strange)) Can we use just japanese candle? |
defkev
force-pushed
the
pr-webui-echarts
branch
2 times, most recently
from
c8c1aa7 to
486c05a
Compare
defkev
force-pushed
the
pr-webui-echarts
branch
from
b1d748e to
c8a111a
Compare
This should drastically improve loading and response time of the dashboard with many datapoints.
* Limit initial zoom to 100 trades * Move candle to the back * Add plot for my_trades
* increase dataZoom startValue to 500 trades * reduce left/right margin * hide Chinese tooltips
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a couple of days uptime the dashboard takes minutes to load, possibly even freezing the whole browser for a few seconds.
I have no idea why plotly.js is struggling so hard with just a few thousand datapoints and i don't even want to know what happens once we reach 10k...i suppose they have a serious memory leak somewhere.
Functionality is pretty much the same, just another library.
After running it for over a week i can indeed confirm it performs a lot better compared to plotly.