Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

adjustments to work on windows #1088

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Conversation

krystophv
Copy link
Contributor

switches out the node-talib dependency for one that's been updated to correctly build on windows and replaces a shell script with some shelljs (already a dependency of the project)

@krystophv
Copy link
Contributor Author

FYI, I have a PR out against the main node-talib project which adds windows support without adding a number of other nested dependencies (which this currently does). Might want to wait to see if that gets merged and then I can update this to just use the new version of node-talib.

Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DeviaVir DeviaVir merged commit b0ff9a3 into DeviaVir:unstable Jan 9, 2018
krystophv added a commit to krystophv/zenbot that referenced this pull request Jan 14, 2018
@krystophv krystophv deleted the windows-support branch February 2, 2018 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants