raise exception instead of NotImplemented

Dazu-io · Feb 21, 2020 · f1cc9a7 · f1cc9a7
1 parent da4b6e2
commit f1cc9a7
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 13 deletions.
diff --git a/rasa/core/policies/ted_policy.py b/rasa/core/policies/ted_policy.py
@@ -457,6 +457,7 @@ def load(cls, path: Text) -> "TEDPolicy":
         return cls(featurizer=featurizer, priority=priority, model=model, **meta)
 
 
+# accessing _tf_layers with any key results in key-error, disable it
 # pytype: disable=key-error
 
 

diff --git a/rasa/nlu/classifiers/diet_classifier.py b/rasa/nlu/classifiers/diet_classifier.py
@@ -925,6 +925,7 @@ def _load_model(
         return model
 
 
+# accessing _tf_layers with any key results in key-error, disable it
 # pytype: disable=key-error
 
 

diff --git a/rasa/utils/tensorflow/models.py b/rasa/utils/tensorflow/models.py
@@ -232,7 +232,7 @@ def train_dataset_function(_batch_size: int) -> tf.data.Dataset:
         )
 
     def _get_tf_evaluation_functions(
-        self, eager: bool, evaluation_model_data: Optional[RasaModelData],
+        self, eager: bool, evaluation_model_data: Optional[RasaModelData]
     ) -> Tuple[Optional[Callable], Optional[Callable]]:
         """Create evaluation tensorflow functions"""
 
@@ -248,10 +248,7 @@ def evaluation_dataset_function(_batch_size: int) -> tf.data.Dataset:
         return (
             evaluation_dataset_function,
             self._get_tf_call_model_function(
-                evaluation_dataset_function,
-                self._total_batch_loss,
-                eager,
-                "evaluation",
+                evaluation_dataset_function, self._total_batch_loss, eager, "evaluation"
             ),
         )
 
@@ -335,22 +332,36 @@ def linearly_increasing_batch_size(
             return int(batch_size[0])
 
     def compile(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def evaluate(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def test_on_batch(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def predict_on_batch(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def fit_generator(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def evaluate_generator(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
 
     def predict_generator(self, *args, **kwargs) -> None:
-        raise NotImplemented
+        raise Exception(
+            "This method should neither be called nor implemented in our code."
+        )
diff --git a/setup.cfg b/setup.cfg
@@ -24,4 +24,4 @@ license_file = LICENSE.txt
 
 [flake8]
 max-line-length = 88
-ignore = W503, E121, E126, E211, E225, E501, E203, E402, F401, F811, E231, F901
+ignore = W503, E121, E126, E211, E225, E501, E203, E402, F401, F811, E231
Original file line number	Diff line number	Diff line change
Expand Up		@@ -457,6 +457,7 @@ def load(cls, path: Text) -> "TEDPolicy":
		return cls(featurizer=featurizer, priority=priority, model=model, **meta)


		# accessing _tf_layers with any key results in key-error, disable it
		# pytype: disable=key-error


Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -925,6 +925,7 @@ def _load_model(
		return model


		# accessing _tf_layers with any key results in key-error, disable it
		# pytype: disable=key-error


Expand Down