Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logs description typo #9764

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Fix logs description typo #9764

merged 4 commits into from
Aug 9, 2021

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Fix logs description typo.

Motivation

#9739 (comment)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223 ian28223 requested review from anshumgargdd and a team as code owners July 25, 2021 04:14
@ian28223 ian28223 mentioned this pull request Jul 25, 2021
Merged
4 tasks
ofek
ofek requested changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh specs too

@ian28223
Copy link
Contributor Author

Oh specs too

Per checking, no spec.yaml needed to be changed. Only had to change the main logs template and the rest followed after sync.
https://github.com/DataDog/integrations-core/pull/9764/files#diff-dda1a34e0be34adfa2ec36c12ee90823b7de45303c213bc999943dbf2bb28c3dR9

@ian28223 ian28223 requested a review from ofek July 26, 2021 01:14
kayayarai
kayayarai previously approved these changes Jul 26, 2021
View reviewed changes
@ofek
Copy link
Contributor

ofek commented Jul 28, 2021 

ddev validate dep changed
File `/home/vsts/work/1/s/pan_firewall/setup.py` missing base check dependency `CHECKS_BASE_REQ`

@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #9764 (86c4999) into master (8e3cbf6) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.93% <ø> (ø)
openstack 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

hithwen
hithwen requested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unrelated file

@ian28223 ian28223 requested a review from hithwen August 4, 2021 10:18
@ofek ofek merged commit d98c2c2 into master Aug 9, 2021
@ofek ofek deleted the ian.bucad/logs_typo branch August 9, 2021 15:58
github-actions bot pushed a commit that referenced this pull request Aug 9, 2021
@ofek
Fix logs description typo (#9764)
1b40a27 
* fix logs template

* revalidate configs

* fix tests

* [04b8a45] fix pan_firewall config not syncing d98c2c2
@ChristineTChen ChristineTChen mentioned this pull request Aug 31, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai approved these changes

@anshumgargdd anshumgargdd Awaiting requested review from anshumgargdd

@ofek ofek Awaiting requested review from ofek

@hithwen hithwen Awaiting requested review from hithwen

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/active_directory integration/activemq_xml integration/activemq integration/aerospike integration/airflow integration/ambari integration/apache integration/cacti integration/cassandra integration/ceph integration/clickhouse integration/cockroachdb integration/confluent_platform integration/consul integration/couch integration/couchbase integration/datadog_checks_dev integration/druid integration/elastic integration/envoy integration/etcd integration/exchange_server integration/flink integration/gearmand integration/gitlab_runner integration/gitlab integration/glusterfs integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/hivemq integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/jboss_wildfly integration/journald integration/kafka integration/kong integration/kyototycoon integration/lighttpd integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_master integration/mesos_slave integration/mongo integration/mysql integration/nagios integration/nfsstat integration/nginx integration/openldap integration/openstack_controller integration/openstack integration/pgbouncer integration/postfix integration/postgres integration/powerdns_recursor integration/presto integration/rabbitmq integration/redisdb integration/rethinkdb integration/riak integration/scylla integration/sidekiq integration/solr integration/sonarqube integration/spark integration/sqlserver integration/squid integration/statsd integration/supervisord integration/teamcity integration/tenable integration/tomcat integration/twemproxy integration/varnish integration/vault integration/vertica integration/voltdb integration/win32_event_log integration/yarn integration/zk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian28223 @ofek @hithwen @kayayarai