Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version parsing #9423

Merged
merged 4 commits into from
May 26, 2021
Merged

Fix version parsing #9423

merged 4 commits into from
May 26, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented May 26, 2021 •
edited
Loading

A customer is getting this error

glusterfs (1.1.2)
    -----------------
     ...
      Error: cannot unpack non-iterable NoneType object
      Traceback (most recent call last):
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/base/checks/base.py", line 897, in run
          self.check(instance)
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/glusterfs/check.py", line 82, in check
          self.submit_version_metadata(data)
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/base/checks/base.py", line 696, in entrypoint
          method(self, *args, **kwargs)
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/glusterfs/check.py", line 111, in submit_version_metadata
          major, minor = self.parse_version(raw_version)
      TypeError: cannot unpack non-iterable NoneType object

It seems some times gluster version may have a patch although we're testing against latest and havent seen it on CI

@hithwen hithwen requested a review from a team as a code owner May 26, 2021 11:37
@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #9423 (bbd8020) into master (fc0dfd0) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Flag Coverage Δ
glusterfs 80.09% <71.42%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
glusterfs/datadog_checks/glusterfs/check.py 68.14% <60.00%> (+0.96%) ⬆️
glusterfs/tests/test_glusterfs.py 100.00% <100.00%> (ø)

@hithwen hithwen merged commit 9611293 into master May 26, 2021
@hithwen hithwen deleted the js/AGENT-6312-capture-gluster-versionn-error branch May 26, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/glusterfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hithwen @ofek @FlorianVeaux