Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config spec example consumer option default to display_default #8593

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 11, 2021

Motivation

The upcoming data model consumer will use the option default as the default value at runtime, which despite the name, currently does not mean that (see for example the vsphere change)

@ofek ofek merged commit e6bce64 into master Feb 11, 2021
@ofek ofek deleted the ofek/cs-default branch February 11, 2021 14:28
@AlexandreYang
Copy link
Member

AlexandreYang commented Feb 12, 2021

changelog/Changed should only apply to ddev change, but integration should use a changelog/Fixed label.

The plan is to:

Step 1: release ddev with changelog/Changed to have a major version bump #8613
Step 2: change label to changelog/Fixed, so other integration with have patch version bump

cc @ofek @FlorianVeaux

ian28223 added a commit that referenced this pull request Jul 21, 2021
Ref: #8593
`display_default` should now be used to generate defaults file
ian28223 added a commit that referenced this pull request Jul 23, 2021
Squashed commits:
[038efa5] use display_default instead of default
Ref: #8593
`display_default` should now be used to generate defaults file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment