Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GlusterFS dashboard logo path #8474

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix GlusterFS dashboard logo path #8474

merged 1 commit into from
Jan 27, 2021

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

Fix path to logo image in GlusterFS dashboard

Motivation

Current path does not exist and results in a "blank" image widget (error in browser console):

GET https://static.datadoghq.com/static/images/saas_logos/bot/[email protected] 403

Fixed path to point to correct path in web-ui: https://github.com/DataDog/web-ui/blob/prod/public/static/images/saas_logos/bot/[email protected]

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from a team as a code owner January 27, 2021 16:01
@florimondmanca florimondmanca merged commit 11c5fb6 into master Jan 27, 2021
@florimondmanca florimondmanca deleted the fm/fix-gluster-dashboard-img branch January 27, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/glusterfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @ChristineTChen