Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Use SVG logos on integration dashboards instead of PNGs #8450

Merged
merged 2 commits into from
Jan 27, 2021
Merged

💄 Use SVG logos on integration dashboards instead of PNGs #8450

merged 2 commits into from
Jan 27, 2021

Conversation

derekhowles
Copy link
Contributor

@derekhowles derekhowles commented Jan 25, 2021 •
edited
Loading

What does this PR do?

Converts PNG integration logos on preset dashboards to their corresponding SVG versions.

In cases where the PNG and SVG file names don't match (most of them), they're updated in accordance with the DRUIDS logo alias map, which is already being used in production throughout the web app-ui, including on the Dash List page.

No layout or any other visual changes — apart from crisp logos.

Motivation

Integration logos are now available as SVGs at a publicly accessible, unversioned path — which means we're able to point to them in an evergreen way. They're always crisp and arbitrarily resizable. For example:

Before After
Screen Shot 2021-01-25 at 5 53 02 PM Screen Shot 2021-01-25 at 5 53 41 PM

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@derekhowles derekhowles changed the title 💄 Use SVG logos on integration dashboards 💄 Use SVG logos on integration dashboards instead of PNGs Jan 25, 2021
@derekhowles derekhowles marked this pull request as ready for review January 26, 2021 22:31
@derekhowles derekhowles requested review from a team as code owners January 26, 2021 22:31
ofek
ofek approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@nmuesch nmuesch merged commit c815e33 into master Jan 27, 2021
@nmuesch nmuesch deleted the derek/svg-dash-logos branch January 27, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/active_directory integration/aerospike integration/airflow integration/amazon_msk integration/ambari integration/apache integration/azure_iot_edge integration/ceph integration/cilium integration/clickhouse integration/cockroachdb integration/confluent_platform integration/coredns integration/crio integration/druid integration/ecs_fargate integration/elastic integration/envoy integration/etcd integration/exchange_server integration/flink integration/gitlab integration/glusterfs integration/haproxy integration/harbor integration/hazelcast integration/hive integration/hivemq integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/istio integration/jboss_wildfly integration/kong integration/linkerd integration/mapr integration/marklogic integration/mcache integration/mongo integration/mysql integration/nginx_ingress_controller integration/nginx integration/openstack integration/oracle integration/postgres integration/presto integration/proxysql integration/redisdb integration/rethinkdb integration/sap_hana integration/scylla integration/sidekiq integration/snowflake integration/systemd integration/tls integration/tomcat integration/twistlock integration/vault integration/vertica integration/vsphere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekhowles @ofek @nmuesch