Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document glusterfs logs support #8411

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Document glusterfs logs support #8411

merged 6 commits into from
Jan 22, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

document logs support: https://github.com/DataDog/logs-backend/pull/15814

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners January 21, 2021 21:29
ruthnaebeck
ruthnaebeck previously requested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

glusterfs/README.md Outdated Show resolved Hide resolved
glusterfs/README.md Outdated Show resolved Hide resolved
glusterfs/README.md Outdated Show resolved Hide resolved
florimondmanca
florimondmanca reviewed Jan 22, 2021
View reviewed changes
glusterfs/manifest.json
Comment on lines +39 to +41
"logs": {
"source": "glusterfs"
},
Copy link
Contributor

@florimondmanca florimondmanca Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Makes me think I forgot to add this in #8385… => #8421

florimondmanca
florimondmanca approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@florimondmanca florimondmanca mentioned this pull request Jan 22, 2021
Merged
4 tasks
@ChristineTChen ChristineTChen merged commit 905e7af into master Jan 22, 2021
@ChristineTChen ChristineTChen deleted the cc/glusterfs-logs branch January 22, 2021 16:22
github-actions bot pushed a commit that referenced this pull request Jan 22, 2021
@ChristineTChen
Document glusterfs logs support (#8411)
13d3853 
* Add log collection

* Add glusterfs logs to config

* Update glusterfs/README.md

Co-authored-by: ruthnaebeck <[email protected]>

* Update glusterfs/README.md

Co-authored-by: ruthnaebeck <[email protected]>

* Update glusterfs/README.md

Co-authored-by: ruthnaebeck <[email protected]>

* Add log source

Co-authored-by: ruthnaebeck <[email protected]> 905e7af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@ruthnaebeck ruthnaebeck Awaiting requested review from ruthnaebeck

Assignees
No one assigned
Labels
documentation integration/glusterfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @florimondmanca @ruthnaebeck