Add ability to dynamically get authentication information #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
dev/tooling
integration/activemq_xml
integration/airflow
integration/amazon_msk
integration/ambari
integration/apache
integration/cilium
integration/cisco_aci
integration/cloud_foundry_api
integration/cockroachdb
integration/consul
integration/couchbase
integration/couch
integration/datadog_checks_base
integration/datadog_checks_dev
integration/druid
integration/elastic
integration/envoy
integration/fluentd
integration/gitlab
integration/gitlab_runner
integration/haproxy
integration/hdfs_datanode
integration/hdfs_namenode
integration/http_check
labels
AlexandreYang
requested changes
Sep 25, 2020
There was a problem hiding this comment.
It I understand correctly, the current use case is about reading token from a file and then writing as request header.
What are the other possible kind of readers and writers ? Having more use cases might help understanding if we need a solution as generic as this one (PR).
That said, I like the flexibility of the implementation.
|
Possible readers:
Possible writers:
|
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
ruthnaebeck
suggested changes
Sep 30, 2020
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
|
@ruthnaebeck I applied your suggestions but removed the period after examples to prevent copy/paste errors. |
ofek
force-pushed
the
ofek/auth-token
branch
2 times, most recently
from
e9da9da
to
3c8f13f
Compare
AlexandreYang
requested changes
Oct 8, 2020
AlexandreYang
previously approved these changes
Oct 8, 2020
AlexandreYang
approved these changes
Oct 8, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Add ability to dynamically get authentication information * Update config specs * incorporate feedback * Apply suggestions from code review Co-authored-by: ruthnaebeck <[email protected]> * sync config * easier default * gracefully retry * update from master * address Co-authored-by: ruthnaebeck <[email protected]> e9bbcf2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Customer request (also eventually can refactor other integrations like OpenMetrics & Vault since we already do similar things)