Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud Foundry event metadata to DataDog event text as serialized JSON #7407

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Add Cloud Foundry event metadata to DataDog event text as serialized JSON #7407

merged 1 commit into from
Aug 20, 2020

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Aug 20, 2020

What does this PR do?

Adds the CF API event metadata to DataDog events as serialized JSON (also makes the event text markdown in order to be able to use preformatted text).

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@bkabrda bkabrda requested a review from a team as a code owner August 20, 2020 11:52
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #7407 into master will increase coverage by 5.87%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
cloud_foundry_api/tests/test_cloud_foundry_api.py 96.59% <ø> (ø)
...adog_checks/cloud_foundry_api/cloud_foundry_api.py 93.70% <100.00%> (+0.39%) ⬆️
ceph/datadog_checks/ceph/__init__.py
gitlab/datadog_checks/gitlab/__init__.py
dns_check/tests/mocks.py
nfsstat/tests/conftest.py
system_swap/tests/conftest.py
couch/datadog_checks/couch/couch.py
postgres/datadog_checks/postgres/util.py
fluentd/datadog_checks/fluentd/__init__.py
... and 728 more

@hithwen hithwen merged commit 0f7b8b2 into master Aug 20, 2020
@hithwen hithwen deleted the slavek.kabrda/cfapi-add-metadata branch August 20, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@therve therve therve approved these changes

Assignees
No one assigned
Labels
integration/cloud_foundry_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkabrda @therve @FlorianVeaux @hithwen