Add space_id and org_id tags in addition to space_guid and org_guid #7382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
nmuesch
reviewed
Aug 17, 2020
| @@ -405,15 +405,22 @@ def build_dd_event( | |||
| org_guid, | |||
| ): | |||
| # type: (str, str, int, str, str, str, str, str, str, str, str) -> Event | |||
| space_id = space_guid if space_guid else "none" | |||
There was a problem hiding this comment.
Wouldn't this leave space_guid to be None instead of the string "none"?
Should this be:
space_id = space_guid = space_guid if space_guid else "none"
(Same as org_id below)
There was a problem hiding this comment.
space_id is used as a value for both space_id: and space_guid: tags - and this is exactly what was used for space_guid previously, so I don't see any issue (or I'm missing something :)).
There was a problem hiding this comment.
Nope, my bad. I missed that it was using the same variable for the value. LGTM
nmuesch
approved these changes
Aug 17, 2020
FlorianVeaux
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
space_idandorg_idtags in addition tospace_guidandorg_guidto make sure users can use the same set of tags as they use for the datadog-firehose-nozzle.Motivation
We should provide usage consistency with https://github.com/DataDog/datadog-firehose-nozzle which submits
org_idandspace_idtags.Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached