Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate example usage of custom config model validators #10927

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Dec 22, 2021

Add documentation on validators.py:

  • when the file does not exist
  • when the file only contains the license header

@hithwen hithwen force-pushed the js/AI-1971-document-validators.py branch from 98fbeee to b07f34a Compare December 22, 2021 12:57
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #10927 (c22c9e0) into master (975f2ef) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Flag Coverage Δ
cilium 85.84% <ø> (+1.88%) ⬆️
dns_check 93.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek changed the title document validators.py Generate example usage of custom config model validators Dec 22, 2021
@hithwen hithwen merged commit 280f25e into master Dec 22, 2021
@hithwen hithwen deleted the js/AI-1971-document-validators.py branch December 22, 2021 16:47
@coignetp coignetp mentioned this pull request Dec 23, 2021
4 tasks
cswatt pushed a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants