Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new container integrations #10577

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Introduce new container integrations #10577

merged 2 commits into from
Nov 10, 2021

Conversation

vboulineau
Copy link
Contributor

@vboulineau vboulineau commented Nov 8, 2021 •
edited
Loading

What does this PR do?

Introduce the new container check (core check) for 7.33. Introduced as a core check by this PR: DataDog/datadog-agent#9403

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@vboulineau vboulineau requested review from a team as code owners November 8, 2021 16:44
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from c34a140 to 66fb10b Compare November 8, 2021 16:55
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

apigirl
apigirl reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small feedbacks from the docs team

container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/manifest.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from fa92d24 to 86edfb3 Compare November 9, 2021 14:19
yzhan289
yzhan289 requested changes Nov 10, 2021
View reviewed changes
container/README.md Outdated Show resolved Hide resolved
container/README.md Show resolved Hide resolved
container/manifest.json Outdated Show resolved Hide resolved
container/README.md Show resolved Hide resolved
container/README.md Show resolved Hide resolved
@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from 86edfb3 to c1bb500 Compare November 10, 2021 15:18
hkaj
hkaj reviewed Nov 10, 2021
View reviewed changes
container/metadata.csv Outdated Show resolved Hide resolved
container/metadata.csv Outdated Show resolved Hide resolved
container/metadata.csv Outdated Show resolved Hide resolved
@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from c1bb500 to 128788d Compare November 10, 2021 15:23
yzhan289
yzhan289 requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing!

container/README.md Outdated Show resolved Hide resolved
@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from 128788d to 9c0bab3 Compare November 10, 2021 16:10
@vboulineau vboulineau force-pushed the vboulineau/container-integration branch from 9c0bab3 to f787ef2 Compare November 10, 2021 16:21
sarah-witt
sarah-witt approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments were addressed!

@vboulineau vboulineau merged commit 0ffde1c into master Nov 10, 2021
@vboulineau vboulineau deleted the vboulineau/container-integration branch November 10, 2021 16:35
github-actions bot pushed a commit that referenced this pull request Nov 10, 2021
@vboulineau
Introduce new container integrations (#10577)
cf04d34 
* Introduce new `container` integrations

* Apply suggestions from code review

Co-authored-by: Kaylyn <[email protected]>

Co-authored-by: Kaylyn <[email protected]> 0ffde1c
@vboulineau vboulineau mentioned this pull request Nov 22, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apigirl apigirl apigirl left review comments

@hkaj hkaj hkaj left review comments

@clamoriniere clamoriniere clamoriniere left review comments

@sarah-witt sarah-witt sarah-witt approved these changes

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vboulineau @clamoriniere @hkaj @apigirl @yzhan289 @sarah-witt