Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README links #10529

Merged
merged 9 commits into from
Nov 8, 2021
Merged

Update README links #10529

merged 9 commits into from
Nov 8, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Nov 1, 2021 •
edited
Loading

What does this PR do?

This PR updates the README links to Agent installation instructions, as some of them were incorrect or overlapped with other links.

Motivation

Clean up READMEs.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested a review from a team as a code owner November 3, 2021 15:04
@yzhan289 yzhan289 changed the title Update READMEs Update README links Nov 3, 2021
alai97
alai97 previously approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs! Good catch on the duplicate "the" there.

You just have one merge conflict to resolve.

@hithwen hithwen requested a review from a team November 4, 2021 09:12
julien-lebot
julien-lebot reviewed Nov 4, 2021
View reviewed changes
voltdb/README.md Show resolved Hide resolved
singlestore/README.md Outdated Show resolved Hide resolved
prometheus/README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
containerd/README.md Outdated Show resolved Hide resolved
cri/README.md Outdated Show resolved Hide resolved
sarina-dd
sarina-dd previously approved these changes Nov 4, 2021
View reviewed changes
julien-lebot
julien-lebot previously approved these changes Nov 5, 2021
View reviewed changes
@yzhan289 yzhan289 mentioned this pull request Nov 5, 2021
Merged
4 tasks
@yzhan289 yzhan289 dismissed stale reviews from julien-lebot and sarina-dd via ea543d6 November 8, 2021 15:06
sarah-witt
sarah-witt previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

alai97
alai97 previously approved these changes Nov 8, 2021
View reviewed changes
sarah-witt
sarah-witt previously approved these changes Nov 8, 2021
View reviewed changes
@yzhan289 yzhan289 dismissed stale reviews from sarah-witt and alai97 via 3a1e7d0 November 8, 2021 19:55
@yzhan289 yzhan289 merged commit b3c1f97 into master Nov 8, 2021
@yzhan289 yzhan289 deleted the az/update-readme branch November 8, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@alai97 alai97 alai97 left review comments

@sarina-dd sarina-dd sarina-dd left review comments

@julien-lebot julien-lebot julien-lebot left review comments

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/aerospike integration/ambari integration/apache integration/avi_vantage integration/azure_iot_edge integration/cilium integration/citrix_hypervisor integration/clickhouse integration/cloud_foundry_api integration/consul_connect integration/containerd integration/cri integration/databricks integration/flink integration/glusterfs integration/gunicorn integration/hazelcast integration/hive integration/hivemq integration/hudi integration/hyperv integration/ibm_db2 integration/ibm_i integration/ignite integration/kube_apiserver_metrics integration/kube_controller_manager integration/kube_metrics_server integration/kube_scheduler integration/marklogic integration/mesos_master integration/nginx_ingress_controller integration/nginx integration/oom_kill integration/openstack_controller integration/openstack integration/otel integration/process integration/prometheus integration/proxysql integration/rethinkdb integration/sap_hana integration/scylla integration/sidekiq integration/singlestore integration/snowflake integration/sonarqube integration/twistlock integration/vertica integration/voltdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yzhan289 @julien-lebot @sarah-witt @sarina-dd @alai97